You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2020/07/21 02:42:12 UTC
[GitHub] [incubator-weex] WJustin opened a new pull request #3244: [iOS]fix: the sticky header in waterfall stays at the bottom when scroll down
WJustin opened a new pull request #3244:
URL: https://github.com/apache/incubator-weex/pull/3244
<!-- First of all, thank you for your contribution!
All PRs should be submitted to master branch -->
<!-- Please follow the template below:
* If you are going to fix a bug of Weex, check whether it already exists in [Github Issue](https://github.com/apache/incubator-weex/issues). If it exists, make sure to write down the link to the corresponding Github issue in the PR you are going to create.
* If you are going to add a feature for weex, reference the following recommend procedure:
1. Writing a email to [mailing list](https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#mailing-list) to talk about what you'd like to do.
1. Write the corresponding [Documentation](https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-documentation)
1. Write the corresponding Changelogs at the end of changelog.md -->
# Brief Description of the PR
# Checklist
* Demo:
* Documentation:
<!-- # Additional content -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-weex] WJustin closed pull request #3244: [iOS]fix: the sticky header in waterfall stays at the bottom when scroll down
Posted by GitBox <gi...@apache.org>.
WJustin closed pull request #3244:
URL: https://github.com/apache/incubator-weex/pull/3244
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on pull request #3244: [iOS]fix: the sticky header in waterfall stays at the bottom when scroll down
Posted by GitBox <gi...@apache.org>.
weex-bot commented on pull request #3244:
URL: https://github.com/apache/incubator-weex/pull/3244#issuecomment-661592386
<!--
1 failure: Code file ios/sdk...
4 warning: No Changelog chan..., Current pr not bi..., If your PR is abo..., If you update the...
DangerID: danger-id-danger;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Code file ios/sdk/WeexSDK/Sources/Component/Recycler/WXMultiColumnLayout.m has cn source code.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
</tr>
<tr>
<td>:warning:</td>
<td>Current pr not bind the milestone</td>
</tr>
<tr>
<td>:warning:</td>
<td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
</tr>
<tr>
<td>:warning:</td>
<td>If you update the code, maybe you should update the documentation and add the documentation link in the PR description.
here is the guide about how to contribute documentation: <a href='https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document'>https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document</a></td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against abd25ba3e57a34d734664a4e7cc1eb18043c84a5
</p>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-weex] WJustin commented on pull request #3244: [iOS]fix: the sticky header in waterfall stays at the bottom when scroll down
Posted by GitBox <gi...@apache.org>.
WJustin commented on pull request #3244:
URL: https://github.com/apache/incubator-weex/pull/3244#issuecomment-661605590
> # Brief Description of the PR
> # Checklist
> * Demo:
> * Documentation:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-weex] weex-bot edited a comment on pull request #3244: [iOS]fix: the sticky header in waterfall stays at the bottom when scroll down
Posted by GitBox <gi...@apache.org>.
weex-bot edited a comment on pull request #3244:
URL: https://github.com/apache/incubator-weex/pull/3244#issuecomment-661592386
<!--
1 failure: Code file ios/sdk...
3 warning: No Changelog chan..., Current pr not bi..., If your PR is abo...
DangerID: danger-id-danger;
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Code file ios/sdk/WeexSDK/Sources/Component/Recycler/WXMultiColumnLayout.m has cn source code.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
</tr>
<tr>
<td>:warning:</td>
<td>Current pr not bind the milestone</td>
</tr>
<tr>
<td>:warning:</td>
<td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against abd25ba3e57a34d734664a4e7cc1eb18043c84a5
</p>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org