[GitHub] [geode] kirklund commented on a change in pull request #7121: GEODE-9817: Enable customized source set paths for ClassAnalysisRule

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #7121:
URL: https://github.com/apache/geode/pull/7121#discussion_r751531918



##########
File path: geode-junit/src/main/java/org/apache/geode/codeAnalysis/AnalyzeDataSerializablesTestBase.java
##########
@@ -340,15 +341,15 @@ private void removeExclusions(Map<String, CompiledClass> classes, List<String> e
   File createEmptyFile(String fileName) throws IOException {
     final String workingDir = System.getProperty("user.dir");
     final String filePath;
-    if (isIntelliJDir(workingDir)) {
-      String buildDir = workingDir.replace(getModuleName(), "");
-      buildDir =
-          Paths.get(buildDir, "out", "production", "geode." + getModuleName() + ".integrationTest")
-              .toString();
-      filePath = buildDir + File.separator + fileName;
-    } else {
-      filePath = fileName;
-    }
+    // if (isIntelliJDir(workingDir)) {
+    // String buildDir = workingDir.replace(getModuleName(), "");
+    // buildDir =
+    // Paths.get(buildDir, "out", "production", "geode." + getModuleName() + ".integrationTest")
+    // .toString();
+    // filePath = buildDir + File.separator + fileName;
+    // } else {
+    filePath = fileName;
+    // }

Review comment:
       This code doesn't seem to be needed when running in IntelliJ. Delete it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org