[GitHub] [commons-imaging] Glavo commented on a diff in pull request #254: [IMAGING-339] Basic WebP Support

["Glavo (via GitHub)" <gi...@apache.org>]

Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1342187578


##########
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunkVp8x.java:
##########
@@ -42,76 +44,105 @@
  * }</pre>
  *
  * @see <a href="https://developers.google.com/speed/webp/docs/riff_container#extended_file_format">Extended File Format</a>
- *
  * @since 1.0-alpha4
  */
-public final class WebPChunkVP8X extends WebPChunk {
-    private final boolean hasICC;
-    private final boolean hasAlpha;
-    private final boolean hasExif;
-    private final boolean hasXmp;
-    private final boolean isAnimation;
+public final class WebPChunkVp8x extends WebPChunk {
+    private final boolean icc;

Review Comment:
   Should these field names be renamed? Referring to `PamFileInfo`, perhaps it would be better for us to keep the 'has' prefix in the field name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org