You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/26 00:17:50 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13349: refactor: Share sql lab query
codecov[bot] commented on pull request #13349:
URL: https://github.com/apache/superset/pull/13349#issuecomment-786319321
# [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=h1) Report
> Merging [#13349](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=desc) (b785d62) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **decrease** coverage by `4.79%`.
> The diff coverage is `60.34%`.
[](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13349 +/- ##
==========================================
- Coverage 77.19% 72.40% -4.80%
==========================================
Files 864 583 -281
Lines 44921 21236 -23685
Branches 5403 5505 +102
==========================================
- Hits 34677 15375 -19302
+ Misses 10121 5738 -4383
Partials 123 123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.09% <22.50%> (-0.45%)` | :arrow_down: |
| javascript | `62.54% <60.00%> (+0.30%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `44.70% <ø> (-24.28%)` | :arrow_down: |
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.15% <0.00%> (+4.50%)` | :arrow_up: |
| [...rc/common/components/Collapse/Collapse.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL0NvbGxhcHNlLnN0b3JpZXMudHN4) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/common/components/Collapse/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0NvbGxhcHNlL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...-frontend/src/common/components/common.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2NvbW1vbi5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...mponents/AsyncAceEditor/AsyncAceEditor.stories.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvQXN5bmNBY2VFZGl0b3Iuc3Rvcmllcy50c3g=) | `0.00% <0.00%> (ø)` | |
| [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `87.75% <ø> (ø)` | |
| [...rset-frontend/src/components/DeleteModal/index.tsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/Icons/icons.stories.jsx](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaWNvbnMuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ø)` | |
| ... and [358 more](https://codecov.io/gh/apache/superset/pull/13349/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=footer). Last update [b5379bc...3342a00](https://codecov.io/gh/apache/superset/pull/13349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org