[GitHub] [cordova-android] goffioul commented on issue #1020: --release signing not working on cordova-android 9.0.0

[GitBox <gi...@apache.org>]

goffioul commented on issue #1020:
URL: https://github.com/apache/cordova-android/issues/1020#issuecomment-682167206


   I understand that you shouldn't create files manually in `platforms/android`, but you could have a hook that generate the files automatically before build. This technique is actually documented in https://cordova.apache.org/docs/en/latest/guide/platforms/android/#project-configuration. Given that the default values for `cdvReleaseSigningPropertiesFile' and 'cdvDebugSigningPropertiesFile' are also documented, it's not difficult to come up with a scheme where these default signing files are generated by a hook script as part of the build process. Something that doesn't work anymore in `9.0.0` due to this commit https://github.com/apache/cordova-android/commit/3712619f5cd3de5055336e87bfade2bc2407900d. In the previous implementation, there was a check to verify the signing properties file was auto-generated or not. This is now gone. It would probably be useful to document clearly that the default values for `cdvReleaseSigningPropertiesFile` and `cdvDebugSigningPropertiesFile` shouldn'
 t be used, because the corresponding files will be deleted on each build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org