You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "corentin-soriano (via GitHub)" <gi...@apache.org> on 2024/04/15 15:52:05 UTC
[PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
corentin-soriano opened a new pull request, #505:
URL: https://github.com/apache/guacamole-server/pull/505
Adds support for the following hotkeys:
- CTRL+Left arrow = move one word to the left.
- CTRL+Right arrow = move one word to the right.
- CTRL+Backspace = delete the word to the left (allow to avoid closing the tab outside of full screen mode with CTRL+w).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2172975531
> > > Just one request - `#define` things that should be constants.
> >
> >
> > Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?
>
> Well, we're trying to improve that:
>
> https://issues.apache.org/jira/browse/GUACAMOLE-287
While I was at it, I added #define constants for the entirety of the __guac_terminal_send_key function and broke up overly long lines.
Feel free to let me know if I should move the declarations to another file or if it would be better to comment each #define.
Would you prefer that I move the second commit to a new pull request?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2168676458
> > Just one request - `#define` things that should be constants.
>
> Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?
Well, we're trying to improve that:
https://issues.apache.org/jira/browse/GUACAMOLE-287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2175269277
> > > > > Just one request - `#define` things that should be constants.
> > > >
> > > >
> > > > Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?
> > >
> > >
> > > Well, we're trying to improve that:
> > > https://issues.apache.org/jira/browse/GUACAMOLE-287
> >
> >
> > While I was at it, I added #define constants for the entirety of the __guac_terminal_send_key function and broke up overly long lines.
> > Feel free to let me know if I should move the declarations to another file or if it would be better to comment each #define.
> > Would you prefer that I move the second commit to a new pull request?"
>
> Wow, thank you. I'm good with them all being in this pull request, but could you move them to a header file - guessing `terminal.h`?
>
> As far as comments go, to be consistent we'll probably need a comment/documentation for each `#define`, but I'll let @mike-jumper or @jmuehlner add any comments they have on that...
#defines moved to terminal.h
If necessary, I will add a comment by #define rather than by block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2311940739
> > @jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this?
>
> To match our guidelines and existing style, each constant (whether defined by `#define` or otherwise) should have a seperate comment.
I added a comment for each `#define` and performed a rebase to update the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-3481587304
> @corentin-soriano Oops, one thing - the commits should both be tagged for `GUACAMOLE-1943` - even though you're tackling something in the GUACAMOLE-287 issue, it's still being done as part of this issue, so please re-tag that one commit with this Jira issue.
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2173767212
> > > > Just one request - `#define` things that should be constants.
> > >
> > >
> > > Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?
> >
> >
> > Well, we're trying to improve that:
> > https://issues.apache.org/jira/browse/GUACAMOLE-287
>
> While I was at it, I added #define constants for the entirety of the __guac_terminal_send_key function and broke up overly long lines.
>
> Feel free to let me know if I should move the declarations to another file or if it would be better to comment each #define.
>
> Would you prefer that I move the second commit to a new pull request?"
Wow, thank you. I'm good with them all being in this pull request, but could you move them to a header file - guessing `terminal.h`?
As far as comments go, to be consistent we'll probably need a comment/documentation for each `#define`, but I'll let @mike-jumper or @jmuehlner add any comments they have on that...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-3481572792
@corentin-soriano Oops, one thing - the commits should both be tagged for `GUACAMOLE-1943` - even though you're tackling something in the GUACAMOLE-287 issue, it's still being done as part of this issue, so please re-tag that one commit with this Jira issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2310584692
> @jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this?
To match our guidelines and existing style, each constant (whether defined by `#define` or otherwise) should have a seperate comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #505:
URL: https://github.com/apache/guacamole-server/pull/505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2156356064
> Just one request - `#define` things that should be constants.
Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts [guacamole-server]
Posted by "corentin-soriano (via GitHub)" <gi...@apache.org>.
corentin-soriano commented on PR #505:
URL: https://github.com/apache/guacamole-server/pull/505#issuecomment-2308918720
@jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org