You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/03 09:07:43 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #4239: Adding message to ensure ports are open
davidjumani opened a new pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239
## Description
Displays a message so that the user knows to open up the following ports on the management server since the host might be using unsupported firewall management tools
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696009657
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4239: Adding message to ensure ports are open
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668178745
@davidjumani - thx for the PR. I see only comment added, but not really removing the actual code which injects raw iptable rules (iptables -A ....) and which runs the "iptables-save > /etc/sysconfig/iptables" command, and restarts iptables service...
I believe we want ZERO management of the iptables, as the rules from the /etc/sysconfig/iptables are overridden by the rules managed by firewalld (which is installed by default on CentOS 7/8)
/cc @PaulAngus @rhtyd @GabrielBrascher @wido @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-684559576
@davidjumani can you check the centos7 failures, are those caused by regression or env related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671776437
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-674037836
@blueorangutan test ubuntu kvm-ubuntu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-674646921
@blueorangutan test ubuntu kvm-ubuntu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-694900000
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-682316849
<b>Trillian test result (tid-2583)</b>
Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
Total time taken: 52615 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2583-kvm-ubuntu18.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Error` | 0.10 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_11_migrate_vm | `Error` | 48.10 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 97.56 | test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 433.68 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3891.22 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 178.89 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668448714
Packaging result: ✔centos7 ✔debian. JID-1640
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-672550926
<b>Trillian test result (tid-2370)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2370-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1810.31 | test_kubernetes_supported_versions.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r469078352
##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -201,15 +201,15 @@ def check(self):
if not hostname.isSuccess():
raise CloudInternalException("Checking hostname ... [Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your hostname\n")
return True
-
+
class sysConfigServerRedhat(sysConfigServer):
def __init__(self, glbEnv):
super(sysConfigServerRedhat, self).__init__(glbEnv)
self.svo = serviceOpsRedhat()
- self.services = [firewallConfigServer(self)]
Review comment:
okay @davidjumani when you confirm we'll be able to merge this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671828557
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-682336029
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-674897300
Packaging result: ✔centos7 ✔debian. JID-1772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-677015355
@rhtyd Jenkins was failing. Kicking them off now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671892228
@davidjumani env fails to deploy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-673389063
@davidjumani this will require a test round on Ubuntu based mgmt server as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671210431
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-674876572
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-685378918
<b>Trillian test result (tid-2637)</b>
Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
Total time taken: 67832 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2637-kvm-ubuntu18.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 79 look OK, 6 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_extract_Iso | `Failure` | 1082.38 | test_iso.py
test_01_add_delete_kubernetes_supported_version | `Error` | 1803.13 | test_kubernetes_supported_versions.py
test_isolate_network_password_server | `Failure` | 17.53 | test_password_server.py
test_11_migrate_vm | `Error` | 52.61 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 116.38 | test_vm_life_cycle.py
test_02_redundant_VPC_default_routes | `Failure` | 443.33 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 385.90 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3893.27 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 224.88 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-674038253
@davidjumani a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671210203
LGTM
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-694932064
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2042
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-674647132
@davidjumani a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-673935169
@davidjumani can you manually kick test, check lab if an env was deployed at all?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-674875955
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-672043868
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671828307
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-685677789
@rhtyd Looking at the logs, the failures are env related issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668433634
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-694900805
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-676017549
Just a reminder - pl kick test on centos8 and Ubuntu for this @davidjumani (use Jenkins if BO is limiting, thnx)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-672044296
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-683162589
<b>Trillian test result (tid-2584)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56315 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2584-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Error` | 0.10 | test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster | `Error` | 0.07 | test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 0.08 | test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 0.09 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.07 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.05 | test_kubernetes_clusters.py
test_oobm_issue_power_cycle | `Error` | 17.36 | test_outofbandmanagement.py
test_oobm_issue_power_on | `Error` | 18.22 | test_outofbandmanagement.py
test_oobm_issue_power_reset | `Error` | 20.10 | test_outofbandmanagement.py
test_oobm_issue_power_soft | `Error` | 19.77 | test_outofbandmanagement.py
test_oobm_issue_power_status | `Error` | 21.67 | test_outofbandmanagement.py
test_oobm_zchange_password | `Error` | 8.93 | test_outofbandmanagement.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 458.72 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 347.90 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3971.48 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 174.70 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Adding message to ensure ports are open - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668433038
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r468513457
##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -201,15 +201,15 @@ def check(self):
if not hostname.isSuccess():
raise CloudInternalException("Checking hostname ... [Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your hostname\n")
return True
-
+
class sysConfigServerRedhat(sysConfigServer):
def __init__(self, glbEnv):
super(sysConfigServerRedhat, self).__init__(glbEnv)
self.svo = serviceOpsRedhat()
- self.services = [firewallConfigServer(self)]
Review comment:
@davidjumani I think we should revert the previous behaviour and simply print the statement. Otherwise, env will not deploy. Previously the cloudstack-setup-management would open firewall, now that you've changed it - either (a) document this and fix trillian to open the ports both CentOS/Ubuntu envs, or (b) just print the line for information sake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671294257
this needs a test run as changes are in cloudstack-setup-management cc @davidjumani pl kick test when lab is online
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-673392071
@blueorangutan test ubuntu kvm-ubuntu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696009498
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696560611
<b>Trillian test result (tid-2826)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 65712 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2826-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 909.24 | test_kubernetes_supported_versions.py
test_02_vpc_privategw_static_routes | `Failure` | 238.99 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 257.43 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 403.79 | test_privategw_acl.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 422.75 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 172.66 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-682336175
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-673392626
@davidjumani a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671808019
Packaging result: ✔centos7 ✔debian. JID-1707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696089037
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696560611
<b>Trillian test result (tid-2826)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 65712 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2826-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 909.24 | test_kubernetes_supported_versions.py
test_02_vpc_privategw_static_routes | `Failure` | 238.99 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 257.43 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 403.79 | test_privategw_acl.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 422.75 | test_vpc_redundant.py
test_hostha_kvm_host_fencing | `Error` | 172.66 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696089913
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4239: Adding message to ensure ports are open - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668432603
Thanks @andrijapanicsb @wido Made the changes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696009498
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r468514496
##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -201,15 +201,15 @@ def check(self):
if not hostname.isSuccess():
raise CloudInternalException("Checking hostname ... [Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your hostname\n")
return True
-
+
class sysConfigServerRedhat(sysConfigServer):
def __init__(self, glbEnv):
super(sysConfigServerRedhat, self).__init__(glbEnv)
self.svo = serviceOpsRedhat()
- self.services = [firewallConfigServer(self)]
Review comment:
@rhtyd I was able to deploy a kvm env for basic testing, and everything seems to work. Will look into why it failed this time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671775884
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4239: Adding message to ensure ports are open - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-668420572
We do not want to manage iptables indeed. We (CloudStack) should never touch firewalls. That's up to the admin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-683186535
<b>Trillian test result (tid-2591)</b>
Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
Total time taken: 49331 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4239-t2591-kvm-ubuntu18.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_11_migrate_vm | `Error` | 49.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 101.44 | test_vm_life_cycle.py
test_hostha_kvm_host_fencing | `Error` | 103.36 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-696009657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r469192044
##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -201,15 +201,15 @@ def check(self):
if not hostname.isSuccess():
raise CloudInternalException("Checking hostname ... [Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your hostname\n")
return True
-
+
class sysConfigServerRedhat(sysConfigServer):
def __init__(self, glbEnv):
super(sysConfigServerRedhat, self).__init__(glbEnv)
self.svo = serviceOpsRedhat()
- self.services = [firewallConfigServer(self)]
Review comment:
It's good to go. Env came up and smoke tests ran successfully!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org