You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/02/19 09:43:01 UTC
[GitHub] [tinkerpop] heljoyLiu opened a new pull request #1251: Add session
mode in js driver
heljoyLiu opened a new pull request #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette merged pull request #1251: Add session mode
in js driver
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1251: Add session mode
in js driver
Posted by GitBox <gi...@apache.org>.
spmallette commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-594078695
I've merged this one and added some documentation. Thanks @heljoyLiu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] heljoyLiu commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
heljoyLiu commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-593952226
@jorgebay hi, is here some wrong ? I will update it asap
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] heljoyLiu commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
heljoyLiu commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-589464987
now, syntax is ok, but ThinkerGraph don't support transaction.
how about to skip this session test case ? I check it works in local graph which support transaction
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] heljoyLiu commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
heljoyLiu commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-588253697
@greedy , could we set a new version node, v7.6 or other for travis-ci ?
I found async/await failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] heljoyLiu commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
heljoyLiu commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-589910236
> We do test transactions but they only test when Neo4j is present and we only test those with Java test cases. The nature of a session and transactions within a session are already well tested that way. I think that here for a GLV you just want to ensure that the most basic aspect of a session works. The most basic tests to assert that I think would be to create a variable in one request like "x = 1" then in a second request send "x = x + 1" and assert that you get "2" as a result. you may wish to do that in a loop for multiple requests just to demonstrate the ongoing modifications to the session variable "x".
en, get your point, I will change tests for session, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
jorgebay commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-594394172
Thanks @heljoyLiu !!! 🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1251: Add session mode
in js driver
Posted by GitBox <gi...@apache.org>.
spmallette commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-589620238
We do test transactions but they only test when Neo4j is present and we only test those with Java test cases. The nature of a session and transactions within a session are already well tested that way. I think that here for a GLV you just want to ensure that the most basic aspect of a session works. The most basic tests to assert that I think would be to create a variable in one request like "x = 1" then in a second request send "x = x + 1" and assert that you get "2" as a result. you may wish to do that in a loop for multiple requests just to demonstrate the ongoing modifications to the session variable "x".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] heljoyLiu commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
heljoyLiu commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-591764092
> Looks great! thanks @heljoyLiu for including integration tests!
>
> VOTE +1
please apply it as free, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] heljoyLiu commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
heljoyLiu commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-591286248
Hi @spmallette @jorgebay , I copy a sample case from java session, and it's basic aspect, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] spmallette commented on issue #1251: Add session mode
in js driver
Posted by GitBox <gi...@apache.org>.
spmallette commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-591379250
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] jorgebay commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
jorgebay commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-594034996
Sorry for the radio silence, I haven't got time to merge it yet... I hope I can do it soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tinkerpop] heljoyLiu commented on issue #1251: Add session mode in
js driver
Posted by GitBox <gi...@apache.org>.
heljoyLiu commented on issue #1251: Add session mode in js driver
URL: https://github.com/apache/tinkerpop/pull/1251#issuecomment-594350967
> I've merged this one and added some documentation. Thanks @heljoyLiu
Thanks @spmallette for your documentation, I will add session for other Gremlin Language Variants later as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services