You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Eric Erhardt (Jira)" <ji...@apache.org> on 2020/05/21 22:49:00 UTC

[jira] [Comment Edited] (ARROW-8882) [C#] Add .editorconfig to C# code

    [ https://issues.apache.org/jira/browse/ARROW-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113604#comment-17113604 ] 

Eric Erhardt edited comment on ARROW-8882 at 5/21/20, 10:48 PM:
----------------------------------------------------------------

I also learned through doing this work that if you want to fail the build on violations, you need to use some roslyn analyzer (like StyleCop). I'm not sure failing the build on style violations is a great experience, so I didn't enable it with this work. This issue is just to establish the style used in the project and set the .editorconfig settings.


was (Author: eerhardt):
I also learned through doing this work that if you want to fail the build on violations, you need to use some analyzer. I'm not sure failing the build on style violations is a great experience, so I didn't enable it with this work. This issue is just to establish the style used in the project and set the .editorconfig settings.

> [C#] Add .editorconfig to C# code
> ---------------------------------
>
>                 Key: ARROW-8882
>                 URL: https://issues.apache.org/jira/browse/ARROW-8882
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C#
>            Reporter: Eric Erhardt
>            Assignee: Eric Erhardt
>            Priority: Minor
>              Labels: pull-request-available
>   Original Estimate: 3h
>          Time Spent: 20m
>  Remaining Estimate: 2h 40m
>
> This allows for a consistent code format throughout the C# code in the repo. That way when a new contributor submits a change, the editors will automatically format the code to be in the same format as the current code base.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)