You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2012/10/25 15:39:13 UTC
[jira] [Created] (OAK-403) PropertyIndexLookup does not find
indexes
Marcel Reutegger created OAK-403:
------------------------------------
Summary: PropertyIndexLookup does not find indexes
Key: OAK-403
URL: https://issues.apache.org/jira/browse/OAK-403
Project: Jackrabbit Oak
Issue Type: Bug
Components: core
Affects Versions: 0.5
Reporter: Marcel Reutegger
Assignee: Marcel Reutegger
The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486772#comment-13486772 ]
Alex Parvulescu commented on OAK-403:
-------------------------------------
bq And somewhat outside the scope of this issue, I'm not sure why the find() method skips multi-valued properties when the else clause already handles also that case. Same for the TODO on mvp.
Isn't that one and the same issue?
I see the TODO on the find() about mvps and it can effectively be removed by aggregating the results, so I'll do that.
Where is the second one about skipping multi-valued properties?
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu resolved OAK-403.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.6
agreed. marking as resolved.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Fix For: 0.6
>
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated OAK-403:
---------------------------------
Attachment: OAK-403.patch
Attached patch is a work in progress.
Tests pass, except for some order by related tests in the JCR TCK.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486739#comment-13486739 ]
Jukka Zitting commented on OAK-403:
-----------------------------------
Also, do we need the {{reindex = true}} settings in the initial content? The indexing hook should (or at least could) be smart enough to automatically trigger initial indexing when a new index definition is added.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated OAK-403:
---------------------------------
Attachment: OAK-403.patch
All tests pass with this updated patch.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486763#comment-13486763 ]
Jukka Zitting commented on OAK-403:
-----------------------------------
bq. I think the problem is the index def is added on the initial content at a moment when there are no IndexHooks available yet.
Good point. Sounds like we should have the indexing hook in place already before initial content gets installed. I'll follow up in a separate issue.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486758#comment-13486758 ]
Alex Parvulescu commented on OAK-403:
-------------------------------------
> do we need the reindex = true settings in the initial content?
I think the problem is the index def is added on the initial content at a moment when there are no IndexHooks available yet. I think it's safer to mark as 'reindex required' to go around this initialization issue.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486779#comment-13486779 ]
Alex Parvulescu commented on OAK-403:
-------------------------------------
committed with rev 1403651.
I'll still leave the issue open for a bit to clarify if we can tackle the mvn thing.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486738#comment-13486738 ]
Jukka Zitting commented on OAK-403:
-----------------------------------
+1 Though it would be good if the {{getIndexDefinitionNode}} code could somehow be shared between the indexing and the lookup code.
And somewhat outside the scope of this issue, I'm not sure why the {{find()}} method skips multi-valued properties when the else clause already handles also that case. Same for the TODO on mvp.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486834#comment-13486834 ]
Marcel Reutegger commented on OAK-403:
--------------------------------------
I'd rather close this issue and create a new one about the multi-valued property thing.
We are already mixing various issues here...
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (OAK-403) PropertyIndexLookup does not find
indexes
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486758#comment-13486758 ]
Alex Parvulescu edited comment on OAK-403 at 10/30/12 9:14 AM:
---------------------------------------------------------------
> do we need the reindex = true settings in the initial content?
I think the problem is the index def is added on the initial content at a moment when there are no IndexHooks available yet. I think it's safer to mark as 'reindex required' to go around this initialization issue.
> The indexing hook should (or at least could) be smart enough to automatically trigger initial indexing when a new index definition is added.
It already does that (by marking the reindex=true on the new definitions so they can be picked-up for reindexing), but this does not cover the small window at startup when there are no OndexHoosk available yet (see above).
was (Author: alex.parvulescu):
> do we need the reindex = true settings in the initial content?
I think the problem is the index def is added on the initial content at a moment when there are no IndexHooks available yet. I think it's safer to mark as 'reindex required' to go around this initialization issue.
> PropertyIndexLookup does not find indexes
> -----------------------------------------
>
> Key: OAK-403
> URL: https://issues.apache.org/jira/browse/OAK-403
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 0.5
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Attachments: OAK-403.patch, OAK-403.patch
>
>
> The PropertyIndexLookup tries to locate the index by child node name instead of matching the name of the property with the values of the 'propertyNames' property on the index node.
> In addition the paths returned by the find() method are not absolute. This will result in an IllegalArgumentException when the path is turned into a Tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira