You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/08/12 03:45:56 UTC
[GitHub] [kylin] tianhui5 opened a new pull request #1353: KYLIN-4692: Receiver segment name error
tianhui5 opened a new pull request #1353:
URL: https://github.com/apache/kylin/pull/1353
## Proposed changes
bug fix of JIRA: https://issues.apache.org/jira/browse/KYLIN-4692
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1353: KYLIN-4692: Receiver segment name error
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1353:
URL: https://github.com/apache/kylin/pull/1353#issuecomment-672570182
## Pull Request Test Coverage Report for [Build 6241](https://coveralls.io/builds/32694579)
* **1** of **2** **(50.0%)** changed or added relevant lines in **2** files are covered.
* **10** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.005%**) to **28.028%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/StreamingSegmentManager.java](https://coveralls.io/builds/32694579/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FStreamingSegmentManager.java#L671) | 0 | 1 | 0.0%
<!-- | **Total:** | **1** | **2** | **50.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/32694579/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L44) | 1 | 83.33% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/32694579/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/32694579/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/32694579/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **10** | | -->
| Totals | [](https://coveralls.io/builds/32694579) |
| :-- | --: |
| Change from base [Build 6240](https://coveralls.io/builds/32679886): | -0.005% |
| Covered Lines: | 26238 |
| Relevant Lines: | 93613 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 closed pull request #1353: KYLIN-4692: Receiver segment name error
Posted by GitBox <gi...@apache.org>.
tianhui5 closed pull request #1353:
URL: https://github.com/apache/kylin/pull/1353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1353: KYLIN-4692: Receiver segment name error
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1353:
URL: https://github.com/apache/kylin/pull/1353#issuecomment-672565050
Actually, as far as I know, use UTC other than local time zone is not a mistake, it is by design.
I don't want to annoy you, but, honestly, if you didn't have fullly understanding of the original design, I cannot agree with your code change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1353: KYLIN-4692: Receiver segment name error
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1353:
URL: https://github.com/apache/kylin/pull/1353#issuecomment-672565050
Actually, as far as I know, use UTC other than local time zone is not a mistake, it is by design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1353: KYLIN-4692: Receiver segment name error
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1353:
URL: https://github.com/apache/kylin/pull/1353#issuecomment-672622630
OK, thank you for your kindness, here is what I can find, please take a look:
- https://issues.apache.org/jira/browse/KYLIN-4672
- https://issues.apache.org/jira/browse/KYLIN-4010
- http://kylin.apache.org/docs/tutorial/lambda_mode_and_timezone_realtime_olap.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 commented on pull request #1353: KYLIN-4692: Receiver segment name error
Posted by GitBox <gi...@apache.org>.
tianhui5 commented on pull request #1353:
URL: https://github.com/apache/kylin/pull/1353#issuecomment-672590325
> Actually, as far as I know, use UTC other than local time zone is not a mistake, it is by design.
> I don't want to annoy you, but, honestly, if you didn't have fullly understanding of the original design, I cannot agree with your code change.
Never mind, I'll read it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org