You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/03 09:44:53 UTC
[GitHub] [pulsar] HQebupt opened a new pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
HQebupt opened a new pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115
### Motivation
Code cleanup, one local variable in ManagedLedgerImpl is not used.
- retentionSizeQuotaMet
### Modifications
Delete one local variable.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
If `yes` was chosen, please highlight the changes
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [ ] no-need-doc
Code cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt removed a comment on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt removed a comment on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-986389559
>
Thank you very much. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-986409074
> /pulsarbot run-failure-checks
@HQebupt We can use this to rerun flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-986405512
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-991554899
@Shoothzj Hi, Could you please help to merge it because the merging is blocked, At least 1 approving review is required by reviewers with write access. Thank you in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-986365072
@HQebupt please do not delete the backticks (``) for no-need-doc (the correct format is `no-need-doc`), or else Bot can not recognize the label and fails to label the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-986414430
> > /pulsarbot run-failure-checks
>
> @HQebupt We can use this to rerun flaky tests.
Great, thank you Ting brother. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-994495842
>
You are welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-986394607
> @HQebupt please do not delete the backticks (``) for no-need-doc (the correct format is `no-need-doc`), or else Bot can not recognize the label and fails to label the PR.
@Anonymitaet Thanks. It is my first time to create a PR. I had a quick question. Would I trigger the test again since there are 2 failing tasks in 27 test tasks ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-986389559
>
Thank you very much. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-993436514
@hangc0276 @codelipenghui Could you please approve it to merge since it is my first PR and is blocked ? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-993461386
Committed to master branch
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-985373368
@HQebupt:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115#issuecomment-991554899
@Shoothzj Hi, Could you please help to merge it because the merging is blocked, At least 1 approving review is required by reviewers with write access. Thank you in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #13115:
URL: https://github.com/apache/pulsar/pull/13115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org