You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2009/04/01 18:11:13 UTC
[jira] Created: (HADOOP-5607) TestCapacityScheduler fails with NPE
TestCapacityScheduler fails with NPE
------------------------------------
Key: HADOOP-5607
URL: https://issues.apache.org/jira/browse/HADOOP-5607
Project: Hadoop Core
Issue Type: Bug
Components: contrib/capacity-sched, test
Affects Versions: 0.20.0
Reporter: Chris Douglas
Observed on Hudson:
{noformat}
java.lang.NullPointerException
at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:2117)
at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:2153)
at org.apache.hadoop.mapred.JobInProgress.kill(JobInProgress.java:2221)
at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.killJob(TestCapacityScheduler.java:359)
at org.apache.hadoop.mapred.CapacityTaskScheduler.killJobIfInvalidRequirements(CapacityTaskScheduler.java:1431)
at org.apache.hadoop.mapred.CapacityTaskScheduler.jobAdded(CapacityTaskScheduler.java:1463)
at org.apache.hadoop.mapred.JobQueuesManager.jobAdded(JobQueuesManager.java:183)
at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.submitJob(TestCapacityScheduler.java:387)
at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:625)
at org.apache.hadoop.mapred.TestCapacityScheduler.testHighMemoryJobWithInvalidRequirements(TestCapacityScheduler.java:1992)
{noformat}
This was introduced by HADOOP-5565. FakeJobInProgress doesn't pass a JobTracker reference to the subtype cstr, so calling kill() derefs the null JT field.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5607) TestCapacityScheduler fails with NPE
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5607:
----------------------------------
Attachment: 5607-0.patch
Make JT ref final, avoid NPE by only pulling metrics when used (since gc also derefs, should be sufficient)
> TestCapacityScheduler fails with NPE
> ------------------------------------
>
> Key: HADOOP-5607
> URL: https://issues.apache.org/jira/browse/HADOOP-5607
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched, test
> Affects Versions: 0.20.0
> Reporter: Chris Douglas
> Attachments: 5607-0.patch
>
>
> Observed on Hudson:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:2117)
> at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:2153)
> at org.apache.hadoop.mapred.JobInProgress.kill(JobInProgress.java:2221)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.killJob(TestCapacityScheduler.java:359)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.killJobIfInvalidRequirements(CapacityTaskScheduler.java:1431)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.jobAdded(CapacityTaskScheduler.java:1463)
> at org.apache.hadoop.mapred.JobQueuesManager.jobAdded(JobQueuesManager.java:183)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.submitJob(TestCapacityScheduler.java:387)
> at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:625)
> at org.apache.hadoop.mapred.TestCapacityScheduler.testHighMemoryJobWithInvalidRequirements(TestCapacityScheduler.java:1992)
> {noformat}
> This was introduced by HADOOP-5565. FakeJobInProgress doesn't pass a JobTracker reference to the subtype cstr, so calling kill() derefs the null JT field.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5607) TestCapacityScheduler fails with
NPE
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694774#action_12694774 ]
Chris Douglas commented on HADOOP-5607:
---------------------------------------
{noformat}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{noformat}
Once the patch is applied, TestCapacityScheduler passes.
> TestCapacityScheduler fails with NPE
> ------------------------------------
>
> Key: HADOOP-5607
> URL: https://issues.apache.org/jira/browse/HADOOP-5607
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched, test
> Affects Versions: 0.20.0
> Reporter: Chris Douglas
> Attachments: 5607-0.patch
>
>
> Observed on Hudson:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:2117)
> at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:2153)
> at org.apache.hadoop.mapred.JobInProgress.kill(JobInProgress.java:2221)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.killJob(TestCapacityScheduler.java:359)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.killJobIfInvalidRequirements(CapacityTaskScheduler.java:1431)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.jobAdded(CapacityTaskScheduler.java:1463)
> at org.apache.hadoop.mapred.JobQueuesManager.jobAdded(JobQueuesManager.java:183)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.submitJob(TestCapacityScheduler.java:387)
> at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:625)
> at org.apache.hadoop.mapred.TestCapacityScheduler.testHighMemoryJobWithInvalidRequirements(TestCapacityScheduler.java:1992)
> {noformat}
> This was introduced by HADOOP-5565. FakeJobInProgress doesn't pass a JobTracker reference to the subtype cstr, so calling kill() derefs the null JT field.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5607) TestCapacityScheduler fails with
NPE
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694666#action_12694666 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5607:
------------------------------------------------
+1 patch looks good.
> TestCapacityScheduler fails with NPE
> ------------------------------------
>
> Key: HADOOP-5607
> URL: https://issues.apache.org/jira/browse/HADOOP-5607
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched, test
> Affects Versions: 0.20.0
> Reporter: Chris Douglas
> Attachments: 5607-0.patch
>
>
> Observed on Hudson:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:2117)
> at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:2153)
> at org.apache.hadoop.mapred.JobInProgress.kill(JobInProgress.java:2221)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.killJob(TestCapacityScheduler.java:359)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.killJobIfInvalidRequirements(CapacityTaskScheduler.java:1431)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.jobAdded(CapacityTaskScheduler.java:1463)
> at org.apache.hadoop.mapred.JobQueuesManager.jobAdded(JobQueuesManager.java:183)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.submitJob(TestCapacityScheduler.java:387)
> at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:625)
> at org.apache.hadoop.mapred.TestCapacityScheduler.testHighMemoryJobWithInvalidRequirements(TestCapacityScheduler.java:1992)
> {noformat}
> This was introduced by HADOOP-5565. FakeJobInProgress doesn't pass a JobTracker reference to the subtype cstr, so calling kill() derefs the null JT field.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5607) TestCapacityScheduler fails with NPE
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5607:
----------------------------------
Status: Patch Available (was: Open)
> TestCapacityScheduler fails with NPE
> ------------------------------------
>
> Key: HADOOP-5607
> URL: https://issues.apache.org/jira/browse/HADOOP-5607
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched, test
> Affects Versions: 0.20.0
> Reporter: Chris Douglas
> Attachments: 5607-0.patch
>
>
> Observed on Hudson:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:2117)
> at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:2153)
> at org.apache.hadoop.mapred.JobInProgress.kill(JobInProgress.java:2221)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.killJob(TestCapacityScheduler.java:359)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.killJobIfInvalidRequirements(CapacityTaskScheduler.java:1431)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.jobAdded(CapacityTaskScheduler.java:1463)
> at org.apache.hadoop.mapred.JobQueuesManager.jobAdded(JobQueuesManager.java:183)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.submitJob(TestCapacityScheduler.java:387)
> at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:625)
> at org.apache.hadoop.mapred.TestCapacityScheduler.testHighMemoryJobWithInvalidRequirements(TestCapacityScheduler.java:1992)
> {noformat}
> This was introduced by HADOOP-5565. FakeJobInProgress doesn't pass a JobTracker reference to the subtype cstr, so calling kill() derefs the null JT field.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5607) TestCapacityScheduler fails with
NPE
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695448#action_12695448 ]
Hudson commented on HADOOP-5607:
--------------------------------
Integrated in Hadoop-trunk #796 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/796/])
> TestCapacityScheduler fails with NPE
> ------------------------------------
>
> Key: HADOOP-5607
> URL: https://issues.apache.org/jira/browse/HADOOP-5607
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched, test
> Affects Versions: 0.20.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.20.0
>
> Attachments: 5607-0.patch
>
>
> Observed on Hudson:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:2117)
> at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:2153)
> at org.apache.hadoop.mapred.JobInProgress.kill(JobInProgress.java:2221)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.killJob(TestCapacityScheduler.java:359)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.killJobIfInvalidRequirements(CapacityTaskScheduler.java:1431)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.jobAdded(CapacityTaskScheduler.java:1463)
> at org.apache.hadoop.mapred.JobQueuesManager.jobAdded(JobQueuesManager.java:183)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.submitJob(TestCapacityScheduler.java:387)
> at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:625)
> at org.apache.hadoop.mapred.TestCapacityScheduler.testHighMemoryJobWithInvalidRequirements(TestCapacityScheduler.java:1992)
> {noformat}
> This was introduced by HADOOP-5565. FakeJobInProgress doesn't pass a JobTracker reference to the subtype cstr, so calling kill() derefs the null JT field.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5607) TestCapacityScheduler fails with NPE
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5607:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Assignee: Chris Douglas
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this.
> TestCapacityScheduler fails with NPE
> ------------------------------------
>
> Key: HADOOP-5607
> URL: https://issues.apache.org/jira/browse/HADOOP-5607
> Project: Hadoop Core
> Issue Type: Bug
> Components: contrib/capacity-sched, test
> Affects Versions: 0.20.0
> Reporter: Chris Douglas
> Assignee: Chris Douglas
> Fix For: 0.20.0
>
> Attachments: 5607-0.patch
>
>
> Observed on Hudson:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:2117)
> at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:2153)
> at org.apache.hadoop.mapred.JobInProgress.kill(JobInProgress.java:2221)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.killJob(TestCapacityScheduler.java:359)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.killJobIfInvalidRequirements(CapacityTaskScheduler.java:1431)
> at org.apache.hadoop.mapred.CapacityTaskScheduler.jobAdded(CapacityTaskScheduler.java:1463)
> at org.apache.hadoop.mapred.JobQueuesManager.jobAdded(JobQueuesManager.java:183)
> at org.apache.hadoop.mapred.TestCapacityScheduler$FakeTaskTrackerManager.submitJob(TestCapacityScheduler.java:387)
> at org.apache.hadoop.mapred.TestCapacityScheduler.submitJob(TestCapacityScheduler.java:625)
> at org.apache.hadoop.mapred.TestCapacityScheduler.testHighMemoryJobWithInvalidRequirements(TestCapacityScheduler.java:1992)
> {noformat}
> This was introduced by HADOOP-5565. FakeJobInProgress doesn't pass a JobTracker reference to the subtype cstr, so calling kill() derefs the null JT field.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.