You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/04/04 17:35:11 UTC
[GitHub] [hive] zzzzming95 opened a new pull request, #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
zzzzming95 opened a new pull request, #3176:
URL: https://github.com/apache/hive/pull/3176
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
fix hive command Operation bug .
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
jdbc connection hivesrerver2 using dfs command with prefix space will cause exception.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
```
Connection con = DriverManager.getConnection("jdbc:hive2://10.214.35.115:10000/");
Statement stmt = con.createStatement();
// dfs command with prefix space or "\n"
ResultSet res = stmt.executeQuery(" dfs -ls /");
//ResultSet res = stmt.executeQuery("\ndfs -ls /");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary merged pull request #3176: HIVE-26114: Fix jdbc connection hivesrerver2 using dfs command with prefix space will cause exception
Posted by GitBox <gi...@apache.org>.
pvary merged PR #3176:
URL: https://github.com/apache/hive/pull/3176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1108173812
@zzzzming95: You can rerun the tests from the jenkins UI. I restarted them, so if we have a green run, we can merge.
Thanks,
Peter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1108176377
Also started a flaky test checker for the failed test, to see if it is indeed flaky: http://ci.hive.apache.org/job/hive-flaky-check/559/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1088439292
@zzzzming95: Can we have a unit test which fails before the patch, and runs successfully after the patch?
Maybe `TestBeeLineDriver`, or `TestBeeLineWithArgs`, or something like them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1108177418
@zzzzming95: Please ping me later if we have further results here. I expect to be busy this week, and forget things 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zzzzming95 commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
zzzzming95 commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1088429808
@deniskuzZ @pvary @sankarh @adesh-rao @zabetak
It's a simple bug. could you guys please review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pvary commented on pull request #3176: HIVE-26114: Fix jdbc connection hivesrerver2 using dfs command with prefix space will cause exception
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1110596365
@zzzzming95: Any preferred name to use in the commit log? The only full name I have found is `Shezm`
It would look like this:
> HIVE-26114: Fix jdbc connection hivesrerver2 using dfs command with prefix space will cause exception (Shezm reviewed b Peter Vary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zzzzming95 commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
zzzzming95 commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1097429520
@pvary
sorry for the late response... I'll add some UTs later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zzzzming95 commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
zzzzming95 commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1100983724
@kgyrtkirk
Test unstable, please rebuild CI.
@pvary @nrg4878
I add a UT, please review again.
Thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zzzzming95 commented on pull request #3176: HIVE-26114 : jdbc connection hivesrerver2 using dfs command with pref…
Posted by GitBox <gi...@apache.org>.
zzzzming95 commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1110558680
@pvary
Now run green , please merge this pr . thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zzzzming95 commented on pull request #3176: HIVE-26114: Fix jdbc connection hivesrerver2 using dfs command with prefix space will cause exception
Posted by GitBox <gi...@apache.org>.
zzzzming95 commented on PR #3176:
URL: https://github.com/apache/hive/pull/3176#issuecomment-1110605806
@pvary
> HIVE-26114: Fix jdbc connection hivesrerver2 using dfs command with prefix space will cause exception (Shezm reviewed b Peter Vary)
It is OK ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org