[jira] [Commented] (CXF-6127) Check thrown Exception's cause for SOAPFaultException

["Kyle Lape (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247075#comment-14247075 ] 

Kyle Lape commented on CXF-6127:
--------------------------------

I went ahead and pushed the suggested changes to my PR branch.  I did not change the {{Exception}} used in the code after the subcode/locale code if the cause was a {{SOAPFaultException}} due to my explanation in my previous comment.  I can also push the change to the 2.7.x branch and a 3.0.x branch (I realize I hadn't actually opened this) if you're okay with the updated changeset.

> Check thrown Exception's cause for SOAPFaultException
> -----------------------------------------------------
>
>                 Key: CXF-6127
>                 URL: https://issues.apache.org/jira/browse/CXF-6127
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>            Reporter: Kyle Lape
>            Assignee: Akitoshi Yoshida
>
> Section 10.2.2.3 of JAX-WS 2.2 spec has a footnote that says:
> bq. If the exception is a SOAPFaultException or has a cause that is a SOAPFaultException.
> Currently CXF only checks if the thrown exception is of the exact type (i.e. not a subtype of) {{SOAPFaultException}}.  We need to check all causes and may as well use {{instanceof}} rather than {{ex.getClass().equals(SOAPFaultException.class)}} in {{WebFaultOutInterceptor}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)