You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/08 16:28:28 UTC

[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6588: SSD1680 Landscape mode bugfix

adamkaliszan commented on code in PR #6588:
URL: https://github.com/apache/incubator-nuttx/pull/6588#discussion_r916973204


##########
drivers/lcd/ssd1680.c:
##########
@@ -735,7 +733,17 @@ static int ssd1680_configuredisplay(struct ssd1680_dev_s *priv)
 static int ssd1680_update_all_and_redraw(struct ssd1680_dev_s *priv)
 {
   int row;
-  for (row = 0; row < SSD1680_DEV_FB_YRES; row++)
+#if defined(CONFIG_LCD_PORTRAIT) || defined(CONFIG_LCD_RPORTRAIT)
+  const int row_incr = 1;
+#else
+#  if SSD1680_DEV_BPP == 1
+  const int row_incr = 8;
+#  elif

Review Comment:
   Thx. What a stupid mistake....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org