You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/05 09:16:00 UTC

[GitHub] [shardingsphere] jingshanglu opened a new pull request #6639: fix visit subquery in projection

jingshanglu opened a new pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639


   
   Changes proposed in this pull request:
   - change result of visit subquery in projection from ExpressionProjectionSegment to SubqueryProjectionSegment
   - use startIndex instead of PredicateBracketValue 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6639: fix visit subquery in projection

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639#discussion_r466795831



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/predicate/value/PredicateCompareRightValue.java
##########
@@ -28,6 +28,10 @@
 @Getter
 public final class PredicateCompareRightValue implements PredicateRightValue {
     
+    private final int startIndex;

Review comment:
       Do you think it is better to add `SQLSegment` interface for these `PredicateRightValue `?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6639: fix visit subquery in projection

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639#discussion_r466808876



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java
##########
@@ -319,21 +319,11 @@ private PredicateSegment createInSegment(final PredicateContext ctx) {
         return result;
     }
     
-    private PredicateBracketValue createBracketValue(final PredicateContext ctx) {

Review comment:
       Hi @xiyelife  
   Since there are modifications for #4296, could you give the related changes a look? Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #6639: fix visit subquery in projection

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #6639: fix visit subquery in projection

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639#discussion_r466808876



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/oracle/visitor/OracleVisitor.java
##########
@@ -319,21 +319,11 @@ private PredicateSegment createInSegment(final PredicateContext ctx) {
         return result;
     }
     
-    private PredicateBracketValue createBracketValue(final PredicateContext ctx) {

Review comment:
       Hi @xiyelife  
   Since there are some modifications for #4296, could you give the related changes a look? Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] jingshanglu commented on a change in pull request #6639: fix visit subquery in projection

Posted by GitBox <gi...@apache.org>.
jingshanglu commented on a change in pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639#discussion_r466799762



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/predicate/value/PredicateCompareRightValue.java
##########
@@ -28,6 +28,10 @@
 @Getter
 public final class PredicateCompareRightValue implements PredicateRightValue {
     
+    private final int startIndex;

Review comment:
       @tristaZero Now, PredicateRightValue implements SQLSegment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6639: fix visit subquery in projection

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6639:
URL: https://github.com/apache/shardingsphere/pull/6639#issuecomment-671141854


   @jingshanglu Hi thanks for your efforts.
   Look forward to the further `subquery` job. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org