You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "taoseng (via GitHub)" <gi...@apache.org> on 2025/04/30 12:30:08 UTC

[PR] feat(bindings/c): extract the writer closing logic from opendal_writer_free [opendal]

taoseng opened a new pull request, #6128:
URL: https://github.com/apache/opendal/pull/6128

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #6125.
   
   # Rationale for this change
   
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking-changes` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(bindings/c)!: extract the writer closing logic from opendal_writer_free [opendal]

Posted by "yuchanns (via GitHub)" <gi...@apache.org>.
yuchanns commented on PR #6128:
URL: https://github.com/apache/opendal/pull/6128#issuecomment-2853322778

   Now it's fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(bindings/c)!: extract the writer closing logic from opendal_writer_free [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6128:
URL: https://github.com/apache/opendal/pull/6128#issuecomment-2853172375

   Also cc @yuchanns, it looks like we need to collaborate on this. Would you like to push your changes for the Go bindings to this branch directly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(bindings/c)!: extract the writer closing logic from opendal_writer_free [opendal]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #6128:
URL: https://github.com/apache/opendal/pull/6128


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(bindings/c)!: extract the writer closing logic from opendal_writer_free [opendal]

Posted by "yuchanns (via GitHub)" <gi...@apache.org>.
yuchanns commented on PR #6128:
URL: https://github.com/apache/opendal/pull/6128#issuecomment-2853183689

   Sure. Leave it to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat(bindings/c): extract the writer closing logic from opendal_writer_free [opendal]

Posted by "taoseng (via GitHub)" <gi...@apache.org>.
taoseng commented on PR #6128:
URL: https://github.com/apache/opendal/pull/6128#issuecomment-2841840602

   There are still 2 pending items:
   1. Need breaking-changes label.
   2. I notice that the go-binding use c-binding, so go-binding also should be change, but I'm not familiar with the Golang binding part.  @Xuanwo 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org