You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/06/10 15:21:06 UTC

[GitHub] [james-project] chibenwa edited a comment on pull request #487: JAMES-3596 Collocate all server applications in server/apps folder

chibenwa edited a comment on pull request #487:
URL: https://github.com/apache/james-project/pull/487#issuecomment-858707713


   The result is easier to review on the main branch than as a PR...
   
   https://github.com/chibenwa/james-project/tree/JAMES-3596/server/apps
   
    - [x] Apps contains all servers applications: Spring server, Guice servers, CLIs, and their directly related tests
    - [x] Guice servers apps do not contain guice modules. Project that required to be split were split
    - [x] Fixed dead links
    - [x] Renames artifactIds of server/apps to include app in them and not guice
    - [x] Adapted depedencies everywhere needed
    - [x] Apapted ZIP packagings to artifactId changs
    - [x] Adapted READMEs on manual launch to include artifact id changes (guice)
    
    I found that recent changes (before this PR) broke:
    
     - JenkinsFile for stress tests
     - dockerfiles for packaging
     
   I discuss their removal in this mailing list thread: https://www.mail-archive.com/server-dev@james.apache.org/msg70419.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org