You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/12 03:49:53 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27801: [SPARK-31047][SQL] Improve file listing for ViewFileSystem

dongjoon-hyun commented on a change in pull request #27801: [SPARK-31047][SQL] Improve file listing for ViewFileSystem
URL: https://github.com/apache/spark/pull/27801#discussion_r391388029
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
 ##########
 @@ -313,7 +314,7 @@ object InMemoryFileIndex extends Logging {
         // to retrieve the file status with the file block location. The reason to still fallback
         // to listStatus is because the default implementation would potentially throw a
         // FileNotFoundException which is better handled by doing the lookups manually below.
-        case _: DistributedFileSystem if !ignoreLocality =>
+        case (_: DistributedFileSystem | _: ViewFileSystem) if !ignoreLocality =>
 
 Review comment:
   Hi, @manuzhang .
   Which test did you referring in the PR description? Could you add a UT explicitly?
   ```
   ## How was this patch tested?
   
   Existing tests.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org