You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/08/30 14:38:08 UTC
[GitHub] tinkerpop pull request #702: TINKERPOP-1764: Generalize MatchStep to localiz...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/702
TINKERPOP-1764: Generalize MatchStep to localize all barriers, not just reducing barriers.
https://issues.apache.org/jira/browse/TINKERPOP-1764
Prior to this moment, only reducing barrier steps in a `match()`-clause forced the clause to be computed locally (via a `flatMap()`-wrap). However, it has been deemed important to generalize this behavior to all barriers (e.g. `order()`, `limit()`, etc.) as identified by @doanduyhai (Gremlin power user). As such, the generalization has been done, but at the expense of a breaking change. However, realize that this breaking change would only be breaking behavior that is "random" (and most users should not be doing anyways -- but you never know).
*PREVIOUSLY*
```
gremlin> g.V().match(
......1> __.as('a').outE('created').order().by('weight',decr).limit(1).inV().as('b'),
......2> __.as('b').has('lang','java')
......3> ).select('a','b').by('name')
==>[a:marko,b:lop]
```
*CURRENTLY*
```
gremlin> g.V().match(
......1> __.as('a').outE('created').order().by('weight',decr).limit(1).inV().as('b'),
......2> __.as('b').has('lang','java')
......3> ).select('a','b').by('name')
==>[a:marko,b:lop]
==>[a:josh,b:ripple]
==>[a:peter,b:lop]
```
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1764
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #702
----
commit 04b61d5943ecf12338ff15181ff01ba6fd2f143b
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-08-30T14:33:34Z
generalized match() to locally compute with all barriers, not just reducing barriers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #702: TINKERPOP-1764: Generalize MatchStep to localize all b...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/702
Nice upgrade docs - VOTE +1
---
[GitHub] tinkerpop issue #702: TINKERPOP-1764: Generalize MatchStep to localize all b...
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/702
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #702: TINKERPOP-1764: Generalize MatchStep to localiz...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/702
---
[GitHub] tinkerpop issue #702: TINKERPOP-1764: Generalize MatchStep to localize all b...
Posted by doanduyhai <gi...@git.apache.org>.
Github user doanduyhai commented on the issue:
https://github.com/apache/tinkerpop/pull/702
Please remark that the result of _PREVIOUSLY_ is already wrong if we assume that the ordering is global. Indeed the global ordering on `outE('created').values('weight').inV()` should yield {label=software,id=5,lang=java,name=ripple}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---