[GitHub] rabbah commented on a change in pull request #3902: Adda implicit parmaters when getting the namespace identity

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3902: Adda implicit parmaters when getting the namespace identity 
URL: https://github.com/apache/incubator-openwhisk/pull/3902#discussion_r205116453
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/BasicAuthenticationDirective.scala
 ##########
 @@ -73,7 +74,11 @@ object BasicAuthenticationDirective extends AuthenticationDirectiveProvider {
     }
   }
 
-  def identityByNamespace(namespace: EntityName)(implicit transid: TransactionId, authStore: AuthStore) = {
+  def identityByNamespace(namespace: EntityName)(implicit transid: TransactionId,
+                                                 system: ActorSystem,
+                                                 ec: ExecutionContext,
 
 Review comment:
   `ec` and `logging` seem unnecessary at first glance (the actor system can provide one, and if it's for the datastore, then it should already be configured correctly). Re the logging I thought we've been moving away from this pattern.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services