You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Jirsa (JIRA)" <ji...@apache.org> on 2016/11/07 04:47:58 UTC

[jira] [Updated] (CASSANDRA-12788) AbstractReplicationStrategy is not extendable from outside the package

     [ https://issues.apache.org/jira/browse/CASSANDRA-12788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Jirsa updated CASSANDRA-12788:
-----------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 3.0.x)
                       (was: 3.x)
                   3.10
                   3.0.10
    Reproduced In: 3.0.9, 2.2.8, 2.1.16, 2.0.17, 3.x  (was: 2.0.17, 2.1.16, 2.2.8, 3.0.9, 3.x)
           Status: Resolved  (was: Patch Available)

Committed in {{f7aa37142087d93e180b7f7ef8a744543044548f}}, thanks!


> AbstractReplicationStrategy is not extendable from outside the package
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-12788
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12788
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Kurt Greaves
>            Assignee: Kurt Greaves
>             Fix For: 3.0.10, 3.10
>
>         Attachments: 12788-3.0.patch, 12788-3.10.patch, 12788-trunk.patch
>
>
> The constructor for ARS is package-private (no modifier), which means that custom RS implementations cannot call it. That is, calling super(...) fails unless you create your replication strategy inside org.apache.cassandra.locator. This obviously isn't ideal.
> I propose adding protected to the constructor in ARS. The attached patch was against trunk however I believe it should work for 2.1, 2.2, 3.0, and 3.x.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)