You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/05 20:14:17 UTC

[GitHub] [incubator-gobblin] autumnust commented on issue #2910: Add typed config in salesforce

autumnust commented on issue #2910: Add typed config in salesforce
URL: https://github.com/apache/incubator-gobblin/pull/2910#issuecomment-595425499
 
 
   Please go through https://gobblin.readthedocs.io/en/latest/developer-guide/CodingStyle/ for style guidance, also all license header for newly created files are missing. 
   
   Also, an Linkedin-specific test link is not useful for other folks. You may consider unit tests for `ConstraintUtil` to maintain code-coverage. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services