You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2018/04/17 11:35:54 UTC
Review Request 66661: RANGER-2030: Admin UI updates to support policy
effective dates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66661/
-----------------------------------------------------------
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-2030
https://issues.apache.org/jira/browse/RANGER-2030
Repository: ranger
Description
-------
Audit>admin : Show difference view for policy validity period fields in more readable format instead just showing json (UI improvement and done some clean).
Diffs
-----
security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 5d929c1
security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 99e1778
security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 901a1df
security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html d93fcdb
security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 3cbde7a
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 97ad345
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 75c1f64
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html cac71d9
security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html eb37c0b
security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html a943813
security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 58b9efa
Diff: https://reviews.apache.org/r/66661/diff/1/
Testing
-------
Verified diff view for policy validity period.
1.By adding a new validity period while policy creation
2.By adding new row for validity period in existing policy.
3.By updating/deleting the details in the existing validitity period.
Thanks,
Nitin Galave
Re: Review Request 66661: RANGER-2030: Admin UI updates to support
policy effective dates
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66661/#review201372
-----------------------------------------------------------
Please fix warning message.
Applying: RANGER-2030 : Difference view (Audit->Admin tab) support for policy validity period fields
.git/rebase-apply/patch:315: trailing whitespace.
this.collection.add({'attributeName':key, 'newValue':val.toString(),'previousValue': oldResources[key],type : "Policy Resources"});
warning: 1 line adds whitespace errors.
- Qiang Zhang
On April 17, 2018, 11:35 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66661/
> -----------------------------------------------------------
>
> (Updated April 17, 2018, 11:35 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Audit>admin : Show difference view for policy validity period fields in more readable format instead just showing json (UI improvement and done some clean).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 5d929c1
> security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 99e1778
> security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 901a1df
> security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html d93fcdb
> security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 3cbde7a
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 97ad345
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 75c1f64
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html cac71d9
> security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html eb37c0b
> security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html a943813
> security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 58b9efa
>
>
> Diff: https://reviews.apache.org/r/66661/diff/1/
>
>
> Testing
> -------
>
> Verified diff view for policy validity period.
> 1.By adding a new validity period while policy creation
> 2.By adding new row for validity period in existing policy.
> 3.By updating/deleting the details in the existing validitity period.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66661: RANGER-2030: Admin UI updates to support
policy effective dates
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66661/#review201320
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 17, 2018, 11:35 a.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66661/
> -----------------------------------------------------------
>
> (Updated April 17, 2018, 11:35 a.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Audit>admin : Show difference view for policy validity period fields in more readable format instead just showing json (UI improvement and done some clean).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 5d929c1
> security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 99e1778
> security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 901a1df
> security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html d93fcdb
> security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 3cbde7a
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 97ad345
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 75c1f64
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html cac71d9
> security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html eb37c0b
> security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html a943813
> security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 58b9efa
>
>
> Diff: https://reviews.apache.org/r/66661/diff/1/
>
>
> Testing
> -------
>
> Verified diff view for policy validity period.
> 1.By adding a new validity period while policy creation
> 2.By adding new row for validity period in existing policy.
> 3.By updating/deleting the details in the existing validitity period.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66661: RANGER-2030: Admin UI updates to support
policy effective dates
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66661/#review201430
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On April 18, 2018, 2:02 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66661/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 2:02 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2030
> https://issues.apache.org/jira/browse/RANGER-2030
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Audit>admin : Show difference view for policy validity period fields in more readable format instead just showing json (UI improvement and done some clean).
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 5d929c1
> security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 99e1778
> security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 901a1df
> security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html d93fcdb
> security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 3cbde7a
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 97ad345
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 75c1f64
> security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html cac71d9
> security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html eb37c0b
> security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html a943813
> security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 58b9efa
>
>
> Diff: https://reviews.apache.org/r/66661/diff/2/
>
>
> Testing
> -------
>
> Verified diff view for policy validity period.
> 1.By adding a new validity period while policy creation
> 2.By adding new row for validity period in existing policy.
> 3.By updating/deleting the details in the existing validitity period.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 66661: RANGER-2030: Admin UI updates to support
policy effective dates
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66661/
-----------------------------------------------------------
(Updated April 18, 2018, 2:02 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Changes
-------
Fix whitespace error.
Bugs: RANGER-2030
https://issues.apache.org/jira/browse/RANGER-2030
Repository: ranger
Description
-------
Audit>admin : Show difference view for policy validity period fields in more readable format instead just showing json (UI improvement and done some clean).
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js 5d929c1
security-admin/src/main/webapp/scripts/views/reports/PlugableServiceDiffDetail.js 99e1778
security-admin/src/main/webapp/templates/reports/KnoxPolicyDeleteOperationDiff_tmpl.html 901a1df
security-admin/src/main/webapp/templates/reports/KnoxPolicyOperationDiff_tmpl.html d93fcdb
security-admin/src/main/webapp/templates/reports/KnoxPolicyUpdateOperationDiff_tmpl.html 3cbde7a
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html 97ad345
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html 75c1f64
security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html cac71d9
security-admin/src/main/webapp/templates/reports/PolicyDeleteOperationDiff_tmpl.html eb37c0b
security-admin/src/main/webapp/templates/reports/PolicyOperationDiff_tmpl.html a943813
security-admin/src/main/webapp/templates/reports/PolicyUpdateOperationDiff_tmpl.html 58b9efa
Diff: https://reviews.apache.org/r/66661/diff/2/
Changes: https://reviews.apache.org/r/66661/diff/1-2/
Testing
-------
Verified diff view for policy validity period.
1.By adding a new validity period while policy creation
2.By adding new row for validity period in existing policy.
3.By updating/deleting the details in the existing validitity period.
Thanks,
Nitin Galave