You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2017/12/20 18:34:24 UTC

[GitHub] spark pull request #20038: [SPARK-22836][ui] Show driver logs in UI when ava...

GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/20038

    [SPARK-22836][ui] Show driver logs in UI when available.

    Port code from the old executors listener to the new one, so that
    the driver logs present in the application start event are kept.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-22836

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20038
    
----
commit 52641db34bdb9fac5b5808fa2c6334837eeedbc3
Author: Marcelo Vanzin <va...@...>
Date:   2017-12-20T18:29:51Z

    [SPARK-22836][ui] Show driver logs in UI when available.
    
    Port code from the old executors listener to the new one, so that
    the driver logs present in the application start event are kept.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    Retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    **[Test build #85259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85259/testReport)** for PR 20038 at commit [`52641db`](https://github.com/apache/spark/commit/52641db34bdb9fac5b5808fa2c6334837eeedbc3).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    **[Test build #85211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85211/testReport)** for PR 20038 at commit [`52641db`](https://github.com/apache/spark/commit/52641db34bdb9fac5b5808fa2c6334837eeedbc3).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85259/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    **[Test build #85211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85211/testReport)** for PR 20038 at commit [`52641db`](https://github.com/apache/spark/commit/52641db34bdb9fac5b5808fa2c6334837eeedbc3).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20038: [SPARK-22836][ui] Show driver logs in UI when ava...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20038


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    **[Test build #85201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85201/testReport)** for PR 20038 at commit [`52641db`](https://github.com/apache/spark/commit/52641db34bdb9fac5b5808fa2c6334837eeedbc3).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    **[Test build #85201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85201/testReport)** for PR 20038 at commit [`52641db`](https://github.com/apache/spark/commit/52641db34bdb9fac5b5808fa2c6334837eeedbc3).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by squito <gi...@git.apache.org>.
Github user squito commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    lgtm


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85211/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    **[Test build #85259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85259/testReport)** for PR 20038 at commit [`52641db`](https://github.com/apache/spark/commit/52641db34bdb9fac5b5808fa2c6334837eeedbc3).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85201/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

Posted by squito <gi...@git.apache.org>.
Github user squito commented on the issue:

    https://github.com/apache/spark/pull/20038
  
    merged to master


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org