You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2023/01/13 13:33:04 UTC
[GitHub] [pinot] ankitsultana opened a new issue, #10124: [multistage] Aggregation Query with No Grouping Sets Returns Empty Response
ankitsultana opened a new issue, #10124:
URL: https://github.com/apache/pinot/issues/10124
When we run an aggregation query without any grouping-sets, if no rows match the operators under the aggregation then the result is empty. Example:
```
select
count(*)
from
baseballStats_OFFLINE
WHERE
playerID IN (
select
playerID
from
baseballStats_OFFLINE
where
teamID = 'foo'
)
```
The expected behavior here would be to receive a single row `[0]` but instead we don't get any rows. The solution is a bit long. If there are no grouping sets, then we need to reduce the results in a single worker since there's essentially no distribution key to allow for parallel computation.
cc: @walterddr @siddharthteotia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia closed issue #10124: [multistage] Aggregation Query with No Grouping Sets Returns Empty Response
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia closed issue #10124: [multistage] Aggregation Query with No Grouping Sets Returns Empty Response
URL: https://github.com/apache/pinot/issues/10124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #10124: [multistage] Aggregation Query with No Grouping Sets Returns Empty Response
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #10124:
URL: https://github.com/apache/pinot/issues/10124#issuecomment-1410621160
did a bit of research in https://github.com/apache/pinot/commit/18316a3047ba11ac7376719dc5315c0ea948cfd4
it is a bit tricky b/c we rely on the empty row results for distributed global agg/sort to produce correct results (e.g. all data funnel through first server while the rest returns directly EOS)
so in order for this change to merge we also need to make an adjustment for the final aggregation or change the reducer in QueryDispatcher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on issue #10124: [multistage] Aggregation Query with No Grouping Sets Returns Empty Response
Posted by "siddharthteotia (via GitHub)" <gi...@apache.org>.
siddharthteotia commented on issue #10124:
URL: https://github.com/apache/pinot/issues/10124#issuecomment-1414203668
I didn't mean to close this issue. Just merged the other PR and this automatically got closed. Please feel free to reopen this if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #10124: [multistage] Aggregation Query with No Grouping Sets Returns Empty Response
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #10124:
URL: https://github.com/apache/pinot/issues/10124#issuecomment-1414211991
this should be closed. the PR #10222 verifies it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on issue #10124: [multistage] Aggregation Query with No Grouping Sets Returns Empty Response
Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #10124:
URL: https://github.com/apache/pinot/issues/10124#issuecomment-1385870818
yes there's a feature missing in the AggregationOperator where when `_groupByKeyHolder` is empty and `_groupSet` is also empty we should return single row instead of empty row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org