You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Patrick Rhomberg (JIRA)" <ji...@apache.org> on 2017/09/22 17:06:00 UTC

[jira] [Commented] (GEODE-3681) Remove or replace testhooks from the source code.

    [ https://issues.apache.org/jira/browse/GEODE-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176724#comment-16176724 ] 

Patrick Rhomberg commented on GEODE-3681:
-----------------------------------------

I opened a general "remove test hooks" a couple days ago, but appear to have missed AbstractRegionMap as I aggregated the list of offending classes.

I would consider that class a good candidate for the scope of this particular ticket.

> Remove or replace testhooks from the source code.
> -------------------------------------------------
>
>                 Key: GEODE-3681
>                 URL: https://issues.apache.org/jira/browse/GEODE-3681
>             Project: Geode
>          Issue Type: Sub-task
>          Components: tests
>            Reporter: Anilkumar Gingade
>
> In many places we have testhooks written into the product code, that gets shipped to our customer, which is not a good idea. We need to remove/replace these testhooks with better solutions (using mocks?).
> E.g.: Runnable testhook in:
> AbstractRegionMap.testHookRunnableFor48182



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)