[GitHub] [spark] MaxGekk commented on a diff in pull request #43029: [SPARK-45213][SQL] Assign name to the error _LEGACY_ERROR_TEMP_2151

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #43029:
URL: https://github.com/apache/spark/pull/43029#discussion_r1338083914


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -916,6 +916,12 @@
       }
     }
   },
+  "EXPRESSION_DECODING_FAILED" : {
+    "message" : [
+      "Error while decoding: <e>",

Review Comment:
   Let's not include the exception `<e>` to the error message because of:
   1. The message is visible not only to Java/Scala users but also PySpark and SQL users
   2. It is included as `cause` in `SparkRuntimeException`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org