You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/05 20:07:40 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3025: Validate decimal256 with i256 directly

viirya commented on code in PR #3025:
URL: https://github.com/apache/arrow-rs/pull/3025#discussion_r1014721249


##########
arrow-buffer/src/bigint.rs:
##########
@@ -87,6 +87,15 @@ impl i256 {
         }
     }
 
+    /// Create an integer value from its representation as high and low byte arrays in little-endian.

Review Comment:
   I originally wanted that. But I cannot make `from_le_bytes` as const fn. 
   
   ```
   error[E0015]: cannot call non-const fn `Result::<[u8; 16], TryFromSliceError>::unwrap` in constant functions
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org