[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3474: [SCB-2726] add TimeLimiter and Cache governance

[GitBox <gi...@apache.org>]

liubao68 commented on code in PR #3474:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3474#discussion_r1019801392


##########
governance/src/main/java/org/apache/servicecomb/governance/GovernanceConfiguration.java:
##########
@@ -161,6 +164,16 @@ public RetryHandler retryHandler(RetryProperties retryProperties, AbstractRetryE
     return new RetryHandler(retryProperties, retryExtension);
   }
 
+  @Bean
+  public TimeLimiterHandler timeLimiterHandler(TimeLimiterProperties timeLimiterProperties) {
+    return new TimeLimiterHandler(timeLimiterProperties);
+  }
+
+  @Bean
+  public GovernanceCacheHandler<String, Object> getResponseCacheHandler(GovernanceCacheProperties cacheProperties) {

Review Comment:
   bean name `governanceCacheHandler`  is better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org