You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/06/25 10:59:09 UTC
[GitHub] [httpcomponents-client] rafiek commented on a change in pull request #228: HTTPCLIENT-2082
rafiek commented on a change in pull request #228:
URL: https://github.com/apache/httpcomponents-client/pull/228#discussion_r445475784
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java
##########
@@ -70,10 +74,13 @@
*/
public class PoolingHttpClientConnectionManagerBuilder {
+ private Lookup<ConnectionSocketFactory> connectionSocketFactoryRegistry;
private HttpConnectionFactory<ManagedHttpClientConnection> connectionFactory;
private LayeredConnectionSocketFactory sslSocketFactory;
private SchemePortResolver schemePortResolver;
private DnsResolver dnsResolver;
+
+ private StrictConnPool<HttpRoute, ManagedHttpClientConnection> managedConnPool;
Review comment:
It is used in tests, so I added the option to make it part of the `build()`. When omitted, you can still use `PoolConcurrencyPolicy`.
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java
##########
@@ -70,10 +74,13 @@
*/
public class PoolingHttpClientConnectionManagerBuilder {
+ private Lookup<ConnectionSocketFactory> connectionSocketFactoryRegistry;
private HttpConnectionFactory<ManagedHttpClientConnection> connectionFactory;
private LayeredConnectionSocketFactory sslSocketFactory;
private SchemePortResolver schemePortResolver;
private DnsResolver dnsResolver;
+
+ private StrictConnPool<HttpRoute, ManagedHttpClientConnection> managedConnPool;
Review comment:
@ok2c It is used in tests, so I added the option to make it part of the `build()`. When omitted, you can still use `PoolConcurrencyPolicy`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org