[jira] Resolved: (WICKET-2676) DataTable defines newCellItem to take IModel but should really do IModel>

["Igor Vaynberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-2676.
-----------------------------------

    Fix Version/s: 1.5-M2
       Resolution: Fixed

yep, you were right. looks like generics inside datatable are not yet finished and it let this type error slip through. cant change method sig in 1.4.x even though its wrong, fixing in 1.5

> DataTable defines newCellItem to take IModel<T> but should really do IModel<IColumn<T>>
> ---------------------------------------------------------------------------------------
>
>                 Key: WICKET-2676
>                 URL: https://issues.apache.org/jira/browse/WICKET-2676
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.4.5
>            Reporter: Robert Dahlström
>            Assignee: Igor Vaynberg
>             Fix For: 1.5-M2
>
>         Attachments: quickstart.zip
>
>
> The generics support in DataTable seems to not work entirely correctly:
> In the below the override for newCellItem actually gets a Model<IColumn> model, not a Model<T>, so perhaps it should be changed.
> do new AjaxFallbackDefaultDataTable<SomeClass>() {
>    @Override
>    protected Item<SomeClass> newRowItem(String id, int index, IModel<SomeClass> model) {}
>   @Override
>   protected Item<SomeClass> newCellItem(String id, int index, IModel<SomeClass> model) {
>      // Model here is not Model<SomeClass> but Model<IColumn<SomeClass>>
>   }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.