[PR] Do not reset DB in CI tests if not needed [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk opened a new pull request, #44084:
URL: https://github.com/apache/airflow/pull/44084

   The #43979 refactoring of tests caused unnecessary database reset attempts in tests that did not require it or had no database set.
   
   This caused unnecessary `airflow db reset` in collection-only tests with removed non-ARM packages, but also it caused the error printed in non-DB tests:
   
   ```
   Resetting the DB
   
   [2024-11-16T03:50:37.812+0000] {cli_parser.py:67} ERROR - Failed to load CLI commands from executor: LocalExecutor
   Traceback (most recent call last):
     File "/opt/airflow/airflow/cli/cli_parser.py", line 64, in <module>
       executor, _ = ExecutorLoader.import_executor_cls(executor_name)
     File "/opt/airflow/airflow/executors/executor_loader.py", line 285, in import_executor_cls
       return _import_and_validate(executor_name.module_path), executor_name.connector_source
     File "/opt/airflow/airflow/executors/executor_loader.py", line 282, in _import_and_validate
       cls.validate_database_executor_compatibility(executor)
     File "/opt/airflow/airflow/executors/executor_loader.py", line 327, in validate_database_executor_compatibility
       if engine.dialect.name == "sqlite":
   AttributeError: 'NoneType' object has no attribute 'dialect'
   [2024-11-16T03:50:37.813+0000] {cli_parser.py:68} ERROR - Ensure all dependencies are met and try again. If using a Celery based executor install a 3.3.0+ version of the Celery provider. If using a Kubernetes executor, install a 7.4.0+ version of the CNCF provider
   Traceback (most recent call last):
     File "/usr/local/bin/airflow", line 8, in <module>
       sys.exit(main())
     File "/opt/airflow/airflow/__main__.py", line 62, in main
       args.func(args)
     File "/opt/airflow/airflow/cli/cli_config.py", line 49, in command
       return func(*args, **kwargs)
     File "/opt/airflow/airflow/utils/providers_configuration_loader.py", line 55, in wrapped_function
       return func(*args, **kwargs)
     File "/opt/airflow/airflow/cli/commands/db_command.py", line 63, in resetdb
       print(f"DB: {settings.engine.url!r}")
   AttributeError: 'NoneType' object has no attribute 'url'
   
   Database has been reset
   ```
   
   The fix is to add `--no-db-reset` in collection tests and force db_reset = False in case `skip_db_tests` is set to True.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not reset DB in CI tests if not needed [airflow]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #44084:
URL: https://github.com/apache/airflow/pull/44084


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org