You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/29 07:06:32 UTC
[GitHub] [cordova-android] erisu opened a new pull request #910: refactor
(eslint): use cordova-eslint
erisu opened a new pull request #910: refactor (eslint): use cordova-eslint
URL: https://github.com/apache/cordova-android/pull/910
### Motivation and Context
Code syntax cleanup
### Description
* replace dependencies with @cordova/eslint-config
* update eslint config
* eslint corrections
### Testing
- `npm t`
- `npm run eslint`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] NiklasMerz commented on a change in pull request
#910: refactor (eslint): use cordova-eslint
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #910: refactor (eslint): use cordova-eslint
URL: https://github.com/apache/cordova-android/pull/910#discussion_r372319873
##########
File path: bin/templates/cordova/lib/android_sdk.js
##########
@@ -52,13 +52,13 @@ module.exports.print_newest_available_sdk_target = function () {
module.exports.version_string_to_api_level = {
'4.0': 14,
Review comment:
Why are not all of these properties changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #910:
refactor (eslint): use cordova-eslint
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #910: refactor (eslint): use cordova-eslint
URL: https://github.com/apache/cordova-android/pull/910#discussion_r372764890
##########
File path: bin/templates/cordova/lib/android_sdk.js
##########
@@ -52,13 +52,13 @@ module.exports.print_newest_available_sdk_target = function () {
module.exports.version_string_to_api_level = {
'4.0': 14,
Review comment:
Good question, The change was performed eslint automated fixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #910: refactor
(eslint): use cordova-eslint
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #910: refactor (eslint): use cordova-eslint
URL: https://github.com/apache/cordova-android/pull/910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io edited a comment on issue #910:
refactor (eslint): use cordova-eslint
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #910: refactor (eslint): use cordova-eslint
URL: https://github.com/apache/cordova-android/pull/910#issuecomment-579624144
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=h1) Report
> Merging [#910](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/6372ca3fac2462aa8a805c250c1bdd309ad5b346?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `53.19%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/910/graphs/tree.svg?width=650&token=q14nMf6C5a&height=150&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 65.94% 65.94%
=======================================
Files 21 21
Lines 1850 1850
=======================================
Hits 1220 1220
Misses 630 630
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100% <ø> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/android\_sdk.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9hbmRyb2lkX3Nkay5qcw==) | `100% <ø> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==) | `87.33% <ø> (ø)` | :arrow_up: |
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `71.97% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `17.85% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `31.61% <100%> (ø)` | :arrow_up: |
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `93.87% <100%> (ø)` | :arrow_up: |
| [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==) | `76.66% <100%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `89.83% <100%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.2% <25%> (ø)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=footer). Last update [6372ca3...a6b4886](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on a change in pull request #910:
refactor (eslint): use cordova-eslint
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #910: refactor (eslint): use cordova-eslint
URL: https://github.com/apache/cordova-android/pull/910#discussion_r373417551
##########
File path: bin/templates/cordova/lib/android_sdk.js
##########
@@ -52,13 +52,13 @@ module.exports.print_newest_available_sdk_target = function () {
module.exports.version_string_to_api_level = {
'4.0': 14,
Review comment:
I changed it back and disabled eslint around that variable to ensure it remains as strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-android] codecov-io commented on issue #910: refactor
(eslint): use cordova-eslint
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #910: refactor (eslint): use cordova-eslint
URL: https://github.com/apache/cordova-android/pull/910#issuecomment-579624144
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=h1) Report
> Merging [#910](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/6372ca3fac2462aa8a805c250c1bdd309ad5b346?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `53.19%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/910/graphs/tree.svg?width=650&token=q14nMf6C5a&height=150&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #910 +/- ##
=======================================
Coverage 65.94% 65.94%
=======================================
Files 21 21
Lines 1850 1850
=======================================
Hits 1220 1220
Misses 630 630
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/cordova/lib/retry.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9yZXRyeS5qcw==) | `100% <ø> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/android\_sdk.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9hbmRyb2lkX3Nkay5qcw==) | `100% <ø> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==) | `87.33% <ø> (ø)` | :arrow_up: |
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `71.97% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `17.85% <0%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `31.61% <100%> (ø)` | :arrow_up: |
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `93.87% <100%> (ø)` | :arrow_up: |
| [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==) | `76.66% <100%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `89.83% <100%> (ø)` | :arrow_up: |
| [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `51.2% <25%> (ø)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/910/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=footer). Last update [6372ca3...3ec2884](https://codecov.io/gh/apache/cordova-android/pull/910?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org