[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #201: [Feature] Support spark 3.2.0

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #201:
URL: https://github.com/apache/incubator-uniffle/pull/201#discussion_r963195697


##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -483,8 +484,21 @@ private Roaring64NavigableMap getExpectedTasksByExecutorId(
                     shuffleId,
                     startPartition,
                     endPartition);
-      } catch (Exception ee) {
-        throw new RuntimeException(ee);
+      } catch (Exception ignored1) {
+        try {
+          // attempt to use Spark 3.2.0's API

Review Comment:
   Could we add more comments like
   ```
   Each Spark release will be versioned: [MAJOR].[FEATURE].[MAINTENANCE].  Usually we only need to adapt [MAJOR].[FEATURE]. Unfortunately, some interfaces were removed wrongly in Spark 3.2.0. And they were added by Spark 3.2.1. So we need to adapt Spark 3.2.0 here
   ```
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org