You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/07/24 04:55:07 UTC

Review Request 23875: Made WeakFuture::get a const operation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23875/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  3rdparty/libprocess/include/process/future.hpp 5b0ed9b6fdb7e1a4b3250509ee83eb057e3696e5 

Diff: https://reviews.apache.org/r/23875/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 23875: Made WeakFuture::get a const operation.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23875/#review48793
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23874, 23875]

All tests passed.

- Mesos ReviewBot


On July 24, 2014, 2:55 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23875/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 2:55 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 5b0ed9b6fdb7e1a4b3250509ee83eb057e3696e5 
> 
> Diff: https://reviews.apache.org/r/23875/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 23875: Made WeakFuture::get a const operation.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23875/#review48663
-----------------------------------------------------------

Ship it!


Ship It!

- Jiang Yan Xu


On July 23, 2014, 7:55 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23875/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 7:55 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 5b0ed9b6fdb7e1a4b3250509ee83eb057e3696e5 
> 
> Diff: https://reviews.apache.org/r/23875/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>