You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2015/09/18 15:44:28 UTC
Review Request 38490: Phoenix Client package not installed on HDP 2.2
clusters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38490/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Jaimin Jetly.
Bugs: AMBARI-13137
https://issues.apache.org/jira/browse/AMBARI-13137
Repository: ambari
Description
-------
When phoenix is selected the HDP stack is not installing the phoenix package. phoenix package is needed if phoenix is selected or PQS is installed.
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py c930586
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8f56e8f
ambari-server/src/test/python/stacks/2.0.6/configs/default.json a0da7f0
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json PRE-CREATION
Diff: https://reviews.apache.org/r/38490/diff/
Testing
-------
Manually ran all unit tests and added a new one.
Thanks,
Sumit Mohanty
Re: Review Request 38490: Phoenix Client package not installed on HDP
2.2 clusters
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Sept. 18, 2015, 4:53 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py, line 110
> > <https://reviews.apache.org/r/38490/diff/1/?file=1076711#file1076711line110>
> >
> > configurations/hbase-env/phoenix_sql_enabled
> >
> > are you sure that works returing True when needed.
> > Cause I guess it should be
> > /configurations/hbase-env/phoenix_sql_enabled
Worked in the unit tests :-) But I should fix it. Also added the unit test that will verify that phoenix will be deployed.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38490/#review99552
-----------------------------------------------------------
On Sept. 18, 2015, 1:44 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38490/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 1:44 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jaimin Jetly.
>
>
> Bugs: AMBARI-13137
> https://issues.apache.org/jira/browse/AMBARI-13137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When phoenix is selected the HDP stack is not installing the phoenix package. phoenix package is needed if phoenix is selected or PQS is installed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py c930586
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8f56e8f
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json a0da7f0
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38490/diff/
>
>
> Testing
> -------
>
> Manually ran all unit tests and added a new one.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 38490: Phoenix Client package not installed on HDP
2.2 clusters
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38490/#review99552
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py (line 110)
<https://reviews.apache.org/r/38490/#comment156483>
configurations/hbase-env/phoenix_sql_enabled
are you sure that works returing True when needed.
Cause I guess it should be
/configurations/hbase-env/phoenix_sql_enabled
- Andrew Onischuk
On Sept. 18, 2015, 1:44 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38490/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 1:44 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jaimin Jetly.
>
>
> Bugs: AMBARI-13137
> https://issues.apache.org/jira/browse/AMBARI-13137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When phoenix is selected the HDP stack is not installing the phoenix package. phoenix package is needed if phoenix is selected or PQS is installed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py c930586
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8f56e8f
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json a0da7f0
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38490/diff/
>
>
> Testing
> -------
>
> Manually ran all unit tests and added a new one.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 38490: Phoenix Client package not installed on HDP
2.2 clusters
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38490/#review99581
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Sept. 18, 2015, 5:13 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38490/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:13 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jaimin Jetly.
>
>
> Bugs: AMBARI-13137
> https://issues.apache.org/jira/browse/AMBARI-13137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When phoenix is selected the HDP stack is not installing the phoenix package. phoenix package is needed if phoenix is selected or PQS is installed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py c930586
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8f56e8f
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json a0da7f0
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38490/diff/
>
>
> Testing
> -------
>
> Manually ran all unit tests and added a new one.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 38490: Phoenix Client package not installed on HDP
2.2 clusters
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38490/#review99665
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Sept. 18, 2015, 5:13 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38490/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:13 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jaimin Jetly.
>
>
> Bugs: AMBARI-13137
> https://issues.apache.org/jira/browse/AMBARI-13137
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When phoenix is selected the HDP stack is not installing the phoenix package. phoenix package is needed if phoenix is selected or PQS is installed.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py c930586
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8f56e8f
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json a0da7f0
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38490/diff/
>
>
> Testing
> -------
>
> Manually ran all unit tests and added a new one.
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 38490: Phoenix Client package not installed on HDP
2.2 clusters
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38490/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 5:13 p.m.)
Review request for Ambari, Andrew Onischuk and Jaimin Jetly.
Changes
-------
Fixed based on the comment and added another test.
Bugs: AMBARI-13137
https://issues.apache.org/jira/browse/AMBARI-13137
Repository: ambari
Description
-------
When phoenix is selected the HDP stack is not installing the phoenix package. phoenix package is needed if phoenix is selected or PQS is installed.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py c930586
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8f56e8f
ambari-server/src/test/python/stacks/2.0.6/configs/default.json a0da7f0
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_no_phx.json PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json PRE-CREATION
Diff: https://reviews.apache.org/r/38490/diff/
Testing
-------
Manually ran all unit tests and added a new one.
Thanks,
Sumit Mohanty