apr changes

["Gonyou, Austin" <au...@coremetrics.com>]

Has anything changed in the apr lately, for the better? I'm still trying to
use the latest PHP cvs with Apache 2 cvs and I still get this
apr_save_brigade breakage during building. I've asked this on the PHP lists,
but they just get ignored. The only reason I'm writing here is I just really
would like things to work well when/if 2.0.19 is beta. (I'm sure we all
would like to see it happen sooner than later) and I don't know if this is
an implementation in PHP problem or if this is a stemmed problem in the
Apache tree. Thanks for your time guys. Sorry for the bother. 


-------Begin Errors--------
Making all in sapi
make[1]: Entering directory `/home/austin/cvs/php4/sapi'
Making all in apache2filter
make[2]: Entering directory `/home/austin/cvs/php4/sapi/apache2filter'
make[3]: Entering directory `/home/austin/cvs/php4/sapi/apache2filter'
/bin/sh /home/austin/cvs/php4/libtool --silent --mode=compile
/home/austin/cvs/php4/meta_ccld  -I.
-I/home/austin/cvs/php4/sapi/apache2filter -I/home/austin/cvs/php4/main
-I/home/austin/cvs/php4 -I/usr/web-2.0/include -I/home/austin/cvs/php4/Zend
-I/home/austin/cvs/php4/ext/mysql/libmysql
-I/home/austin/cvs/php4/ext/xml/expat -I/home/austin/cvs/php4/TSRM
-D_REENTRANT -I../TSRM -DTHREAD=1 -g -O2 -pthread -prefer-pic  -c
sapi_apache2.c
sapi_apache2.c: In function `php_output_filter':
sapi_apache2.c:337: too few arguments to function `ap_save_brigade'
make[3]: *** [sapi_apache2.lo] Error 1
make[3]: Leaving directory `/home/austin/cvs/php4/sapi/apache2filter'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/austin/cvs/php4/sapi/apache2filter'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/austin/cvs/php4/sapi'
make: *** [all-recursive] Error 1
----end errors-------

-- 
Austin Gonyou
Systems Architect, CCNA
Coremetrics, Inc.
Phone: 512-796-9023
email: austin@coremetrics.com 

Re: apr changes

[Jeff Trawick <tr...@attglobal.net>]

"Gonyou, Austin" <au...@coremetrics.com> writes:

> -D_REENTRANT -I../TSRM -DTHREAD=1 -g -O2 -pthread -prefer-pic  -c
> sapi_apache2.c
> sapi_apache2.c: In function `php_output_filter':
> sapi_apache2.c:337: too few arguments to function `ap_save_brigade'
> make[3]: *** [sapi_apache2.lo] Error 1

There is a new parameter to ap_save_brigade() which is part of a bug
fix.  PHP needs to be updated to pass the new parameter.  You can look
at calls to ap_save_brigade() in Apache for hints on how to fix it.

My guess would be that you could add ", r->pool" or ", f->r->pool"
as the additional parameter to ap_save_brigade(, but I haven't looked
at the PHP code to check.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...