Re: [PR] Read manifests with V3 projection [iceberg-python]

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #3690:
URL: https://github.com/apache/iceberg-python/pull/3690#discussion_r3698120923


##########
pyiceberg/manifest.py:
##########
@@ -532,6 +533,22 @@ def equality_ids(self) -> list[int] | None:
     def sort_order_id(self) -> int | None:
         return self._data[15]
 
+    @property
+    def first_row_id(self) -> int | None:
+        return self._data[16] if len(self._data) > 16 else None

Review Comment:
   I think the following is more Pythonic:
   ```suggestion
           return self._data.get(16)
   ```
   However, this should not be necessary, since when we project the file, we should populate these positions with `None` for all existing V1 or V2 files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org