You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/11/15 19:58:12 UTC
[GitHub] spark pull request #23031: [SPARK-26060][SQL] Track SparkConf entries and ma...
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23031#discussion_r233986989
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala ---
@@ -154,5 +154,9 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new SQLConf) {
if (SQLConf.staticConfKeys.contains(key)) {
throw new AnalysisException(s"Cannot modify the value of a static config: $key")
}
+ if (sqlConf.setCommandRejectsSparkConfs &&
+ ConfigEntry.findEntry(key) != null && !SQLConf.sqlConfEntries.containsKey(key)) {
+ throw new AnalysisException(s"Cannot modify the value of a spark config: $key")
--- End diff --
Spark
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org