You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by lunaru <gi...@git.apache.org> on 2017/07/27 00:47:14 UTC

[GitHub] cordova-plugin-statusbar pull request #83: CB-13124: Add option for native s...

GitHub user lunaru opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/83

    CB-13124: Add option for native scroll-to-top on WebView

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds "StatusBarDefaultScrollToTop" option to allow developer to re-enable native scroll-to-top behavior on the WebView
    
    The motivation for this is described here: https://issues.apache.org/jira/browse/CB-13124


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lunaru/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #83
    
----
commit d215a30bc143c163651914d16426d952ff90d677
Author: Lu Wang <ul...@gmail.com>
Date:   2017-07-26T22:59:36Z

    scrollViewShouldScrollToTop to YES
    
    Make scroll to top happen

commit 5719ab8acfee0fda3da94dd7ecb4071f8b650633
Author: Lu Wang <ul...@gmail.com>
Date:   2017-07-27T00:22:30Z

    Add preference for native scroll to top
    
    Allow default web scroll view to use native scroll to top

commit 09887dea712162cf50134d3f192ff61de636274a
Author: Lu Wang <ul...@gmail.com>
Date:   2017-07-27T00:30:49Z

    Update Readme for StatusBarDefaultScrollToTop

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by lunaru <gi...@git.apache.org>.
Github user lunaru commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    @jcesarmobile does sending to the email list require any permissions? I sent it to dev@cordova.apache.org. I'll try again with my other email address.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    @lunaru I've not seen the mail on the list


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    @lunaru both of them just arrived, will answer there, thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by lunaru <gi...@git.apache.org>.
Github user lunaru commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    @jcesarmobile hey -- i haven't seen any updates on this. any concerns? It would be really nice to have this in the main branch.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by lunaru <gi...@git.apache.org>.
Github user lunaru commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    Hey guys, I'd love to get some feedback on this PR. Let me know if there are any questions. We're now using the fork in production and it's helped a lot with the scroll-to-top quirkiness that a pure javascript implementation exhibits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by lunaru <gi...@git.apache.org>.
Github user lunaru commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    @jcesarmobile thanks, email sent.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by lunaru <gi...@git.apache.org>.
Github user lunaru commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    @alsorokin @jcesarmobile hey guys, I know you've probably been busy with the iPhone X related fixes, but I'd love to get this branch merged in as well. Let me know if there are any questions.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    @lunaru the PR looks good to me, but new features should be discussed on the developer list. Can you send a mail to dev@cordova.apache.org?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by lunaru <gi...@git.apache.org>.
Github user lunaru commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    Hey, just checking in on this PR as it's been very quiet on this project. Let me know if there are any questions about the fix.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by Hirbod <gi...@git.apache.org>.
Github user Hirbod commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    When will this important feature land?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #83: CB-13124: Add option for native scroll-t...

Posted by hengwoon <gi...@git.apache.org>.
Github user hengwoon commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/83
  
    This would be extremely useful since it allows re-scrolling while a momentum scroll is in progress. Would be great if we can get this support in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org