You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/23 17:16:22 UTC
[GitHub] [flink] dannycranmer opened a new pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
dannycranmer opened a new pull request #15347:
URL: https://github.com/apache/flink/pull/15347
## What is the purpose of the change
Gracefully handle Interrupted exceptions in Kinesis EFO source consumer.
## Brief change log
- Update error handling to treat Interrupted exceptions as non-recoverable
- Introduced a `CANCELLED` result for record publisher to cause `ShardConsumer` to terminate
- Do not retry when KinesisDataFetcher is not running (shutdown started) and Thread not yet interrupted
## Verifying this change
- Unit tests
- Kinesis e2e test
- Running locally with 400 shard stream and 25 parallelism
- Deployed to test bed of continuously running applications in AWS KDA
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-805098241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303",
"triggerID" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86cef1cc8c4b61d5896b348acd566f2b28c7259a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
dannycranmer merged pull request #15347:
URL: https://github.com/apache/flink/pull/15347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-805098241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303",
"triggerID" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"triggerType" : "PUSH"
}, {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15404",
"triggerID" : "806039332",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 86cef1cc8c4b61d5896b348acd566f2b28c7259a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15404)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-805083002
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 86cef1cc8c4b61d5896b348acd566f2b28c7259a (Tue Mar 23 17:19:25 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-805098241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303",
"triggerID" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86cef1cc8c4b61d5896b348acd566f2b28c7259a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-805098241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303",
"triggerID" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"triggerType" : "PUSH"
}, {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15404",
"triggerID" : "806039332",
"triggerType" : "MANUAL"
}, {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303",
"triggerID" : "806039332",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 86cef1cc8c4b61d5896b348acd566f2b28c7259a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15404) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-806039332
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-805098241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303",
"triggerID" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"triggerType" : "PUSH"
}, {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15404",
"triggerID" : "806039332",
"triggerType" : "MANUAL"
}, {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303",
"triggerID" : "806039332",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 86cef1cc8c4b61d5896b348acd566f2b28c7259a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15404) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=15303)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15347: [FLINK-21933][kinesis] EFO consumer treats interrupts as retryable ex…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15347:
URL: https://github.com/apache/flink/pull/15347#issuecomment-805098241
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86cef1cc8c4b61d5896b348acd566f2b28c7259a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86cef1cc8c4b61d5896b348acd566f2b28c7259a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org