[GitHub] [nifi] szaboferee commented on a change in pull request #3344: NIFI-6092 Create ListenSlack and FetchSlack processors

[GitBox <gi...@apache.org>]

szaboferee commented on a change in pull request #3344: NIFI-6092 Create ListenSlack and FetchSlack processors
URL: https://github.com/apache/nifi/pull/3344#discussion_r265516056
 
 

 ##########
 File path: nifi-nar-bundles/nifi-slack-bundle/nifi-slack-services-api/src/main/java/org/apache/nifi/processors/slack/controllers/SlackConnectionService.java
 ##########
 @@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.slack.controllers;
+
+import java.util.function.Consumer;
+
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.controller.ControllerService;
+import org.apache.nifi.processor.Processor;
+
+@CapabilityDescription("This service provides a connection to slack")
+public interface SlackConnectionService extends ControllerService {
 
 Review comment:
   You can receive slack messages on the Real Time Messaging API where the client connects to a WebSocket server or you can expose an HTTP endpoint to get called by slack via the  Events API. Currently, I have implemented only the RTM client and wanted to provide the possibility to add an Events API implementation later.
   The other benefit would be that the user needs only one CS to listen and multiple processors could use the same connection (WebSocket in this case). for example, one processor filters "message" type and another "file_shared" type and they can share the same slack connection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services