You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/11/14 05:23:22 UTC
[6/6] hbase git commit: HBASE-19249 test for "hbase antipatterns"
should check _count_ of occurance rather than text of
HBASE-19249 test for "hbase antipatterns" should check _count_ of occurance rather than text of
Signed-off-by: Apekshit Sharma <ap...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/434097db
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/434097db
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/434097db
Branch: refs/heads/branch-1.1
Commit: 434097db0fe6e7f47097446a4061bf2133ae8b83
Parents: c4e3ad0
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Nov 13 16:12:32 2017 -0600
Committer: Sean Busbey <bu...@apache.org>
Committed: Mon Nov 13 23:18:57 2017 -0600
----------------------------------------------------------------------
dev-support/hbase-personality.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/434097db/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 24f2ef5..44cbecb 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -431,15 +431,15 @@ function hbaseanti_patchfile
start_clock
- warnings=$(${GREP} 'new TreeMap<byte.*()' "${patchfile}")
+ warnings=$(${GREP} -c 'new TreeMap<byte.*()' "${patchfile}")
if [[ ${warnings} -gt 0 ]]; then
- add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted: ${warnings}."
+ add_vote_table -1 hbaseanti "" "The patch appears to have anti-pattern where BYTES_COMPARATOR was omitted."
((result=result+1))
fi
- warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
+ warnings=$(${GREP} -c 'import org.apache.hadoop.classification' "${patchfile}")
if [[ ${warnings} -gt 0 ]]; then
- add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
+ add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase."
((result=result+1))
fi