You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/22 03:27:49 UTC

[GitHub] [calcite] hsyuan commented on issue #1354: [CALCITE-482] Implement sql and planner hints

hsyuan commented on issue #1354: [CALCITE-482] Implement sql and planner hints
URL: https://github.com/apache/calcite/pull/1354#issuecomment-544791525
 
 
   - I saw you are supporting `WITH` hint. I am against on supporting it. 1 single style  `/*+ */` would suffice.
   - `RelWithHint` gives me impression that it is still a RelNode class. `Hintable` or `IHint` or other name may be better? Similarly, `RelHint` is a relational node? But it is not.  `HintNode` might be better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services