You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liutang123 <gi...@git.apache.org> on 2017/11/08 09:35:30 UTC
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
GitHub user liutang123 opened a pull request:
https://github.com/apache/spark/pull/19692
[SPARK-22469][SQL] Accuracy problem in comparison with string and numeric
## What changes were proposed in this pull request?
When compare string and numeric, cast them as double like Hive.
## How was this patch tested?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liutang123/spark SPARK-22469
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19692.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19692
----
commit aada8eec812348062d7ef6413342f7676e2b5fab
Author: liutang123 <li...@yeah.net>
Date: 2017-11-08T09:30:14Z
[SPARK-22469][SQL] Accuracy problem in comparison with string and numeric
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83816/testReport)** for PR 19692 at commit [`aada8ee`](https://github.com/apache/spark/commit/aada8eec812348062d7ef6413342f7676e2b5fab).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83829/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by liutang123 <gi...@git.apache.org>.
Github user liutang123 commented on the issue:
https://github.com/apache/spark/pull/19692
@cloud-fan Would you please look at this when you have time?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
Posted by liutang123 <gi...@git.apache.org>.
Github user liutang123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19692#discussion_r149659840
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
@@ -137,6 +137,8 @@ object TypeCoercion {
case (DateType, TimestampType) => Some(StringType)
case (StringType, NullType) => Some(StringType)
case (NullType, StringType) => Some(StringType)
+ case (n: NumericType, s: StringType) => Some(DoubleType)
+ case (s: StringType, n: NumericType) => Some(DoubleType)
--- End diff --
This solved DecimalType but may also have known error.
For example:
`select '1.01' > 1.0;` // false
Is it possible to use DecimalType.SYSTEM_DEFAULT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by liutang123 <gi...@git.apache.org>.
Github user liutang123 commented on the issue:
https://github.com/apache/spark/pull/19692
Jenkins, retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83891/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
Posted by liutang123 <gi...@git.apache.org>.
Github user liutang123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19692#discussion_r150726583
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
@@ -137,6 +137,8 @@ object TypeCoercion {
case (DateType, TimestampType) => Some(StringType)
case (StringType, NullType) => Some(StringType)
case (NullType, StringType) => Some(StringType)
+ case (n: NumericType, s: StringType) => Some(DoubleType)
+ case (s: StringType, n: NumericType) => Some(DoubleType)
--- End diff --
Because `select '1.1' >1` returns false, I prefer casting all NumericType to double like hive.
Therefore, casting decimal to double looks better for me.
But, in our cluster, many users write SQL like `select '1.1' > 1`, this compatibility brings great difficulties to transferring hive task to spark task. So, don't we really need to think about casting all NumericType to double?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83816/testReport)** for PR 19692 at commit [`aada8ee`](https://github.com/apache/spark/commit/aada8eec812348062d7ef6413342f7676e2b5fab).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19692#discussion_r150734871
--- Diff: sql/core/src/test/resources/sql-tests/results/predicate-functions.sql.out ---
@@ -197,7 +197,7 @@ true
-- !query 24
select 2.0 <= '2.2'
-- !query 24 schema
-struct<(2.0 <= CAST(2.2 AS DECIMAL(2,1))):boolean>
+struct<(CAST(2.0 AS DOUBLE) <= CAST(2.2 AS DOUBLE)):boolean>
-- !query 24 output
true
--- End diff --
Add a test case in this file?
select '1.5' > 0.5
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19692#discussion_r150751617
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
@@ -137,6 +137,8 @@ object TypeCoercion {
case (DateType, TimestampType) => Some(StringType)
case (StringType, NullType) => Some(StringType)
case (NullType, StringType) => Some(StringType)
+ case (n: DecimalType, s: StringType) => Some(DoubleType)
--- End diff --
add a comment to say that there is no proper decimal type we can pick, using double type is the best we can do.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19692
Thanks! Merged to master.
@liutang123 Could you submit a PR to backport it to the Spark-2.2 branch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83891 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83891/testReport)** for PR 19692 at commit [`cb1c8b8`](https://github.com/apache/spark/commit/cb1c8b863643a5376b86e4c9d466165c38bf022b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83829/testReport)** for PR 19692 at commit [`9c5bba0`](https://github.com/apache/spark/commit/9c5bba05894ac1dbb7f175bcc083c5c9a6d291fb).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by liutang123 <gi...@git.apache.org>.
Github user liutang123 commented on the issue:
https://github.com/apache/spark/pull/19692
Sorry, I just saw it.
Thank fan for doing this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83820 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83820/testReport)** for PR 19692 at commit [`cf09358`](https://github.com/apache/spark/commit/cf093588e69f9a123475312f0fa2ae5ebfb5ee49).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83891 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83891/testReport)** for PR 19692 at commit [`cb1c8b8`](https://github.com/apache/spark/commit/cb1c8b863643a5376b86e4c9d466165c38bf022b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19692
backported to 2.2 and manually fixed the conflict.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19692
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83820/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19692#discussion_r150697438
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
@@ -137,6 +137,8 @@ object TypeCoercion {
case (DateType, TimestampType) => Some(StringType)
case (StringType, NullType) => Some(StringType)
case (NullType, StringType) => Some(StringType)
+ case (n: NumericType, s: StringType) => Some(DoubleType)
+ case (s: StringType, n: NumericType) => Some(DoubleType)
--- End diff --
How about we cast both sides to double for string and decimal combo? We can't find a proper decimal precision anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83833 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83833/testReport)** for PR 19692 at commit [`cb1c8b8`](https://github.com/apache/spark/commit/cb1c8b863643a5376b86e4c9d466165c38bf022b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83833/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19692
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19692
@liutang123 can you update your PR description to say this fixes a problem caused by #15880 .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19692
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83816/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83829/testReport)** for PR 19692 at commit [`9c5bba0`](https://github.com/apache/spark/commit/9c5bba05894ac1dbb7f175bcc083c5c9a6d291fb).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83833 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83833/testReport)** for PR 19692 at commit [`cb1c8b8`](https://github.com/apache/spark/commit/cb1c8b863643a5376b86e4c9d466165c38bf022b).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19692: [SPARK-22469][SQL] Accuracy problem in comparison...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19692#discussion_r149639379
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
@@ -137,6 +137,8 @@ object TypeCoercion {
case (DateType, TimestampType) => Some(StringType)
case (StringType, NullType) => Some(StringType)
case (NullType, StringType) => Some(StringType)
+ case (n: NumericType, s: StringType) => Some(DoubleType)
+ case (s: StringType, n: NumericType) => Some(DoubleType)
--- End diff --
We intentionally not to do it, see https://github.com/apache/spark/pull/15880 .
But your use case is valid, I think casting string to the decimal type of the other side is too strict, how about
```
case (_: StringType, d: DecimalType) => DecimalPrecision.widerDecimalType(DecimalType.SYSTEM_DEFAULT, d)
```
cc @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19692
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19692
**[Test build #83820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83820/testReport)** for PR 19692 at commit [`cf09358`](https://github.com/apache/spark/commit/cf093588e69f9a123475312f0fa2ae5ebfb5ee49).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19692: [SPARK-22469][SQL] Accuracy problem in comparison with s...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19692
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org