You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/21 04:48:29 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1087: feat(CI): no need to build web after being merged
juzhiyuan opened a new pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- Related issues
None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-748759062
Not all prs do `merge master` before they being merged, so IMHO CI can run after pr merges to check if there are any problems in merge action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-749339188
why backend CI failed again 😢
@nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-748755523
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=h1) Report
> Merging [#1087](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=desc) (985879a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa884a1fb6944c799cd7d9fb3ef943df52b820b?el=desc) (1fa884a) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
+ Coverage 41.00% 41.06% +0.05%
==========================================
Files 28 28
Lines 1773 1773
==========================================
+ Hits 727 728 +1
+ Misses 940 939 -1
Partials 106 106
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1087/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=footer). Last update [1fa884a...985879a](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-748755523
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=h1) Report
> Merging [#1087](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=desc) (c4a4da4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/daded2170383c788892a875b8c0a95f7b824bad0?el=desc) (daded21) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1087 +/- ##
=======================================
Coverage 39.33% 39.33%
=======================================
Files 27 27
Lines 1673 1673
=======================================
Hits 658 658
Misses 915 915
Partials 100 100
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=footer). Last update [daded21...c4a4da4](https://codecov.io/gh/apache/apisix-dashboard/pull/1087?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-749304688
Hi @liuxiran, just enabled the **Update branch**, could we reconsider the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-748764761
🤔 I remember there has one button to let us rebase master before merging, but I couldn't find it recently 😂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1087: feat(CI): no need to build web after being merged
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1087:
URL: https://github.com/apache/apisix-dashboard/pull/1087#issuecomment-749312816
> 
>
> Hi @liuxiran, just enabled the **Update branch**, could we reconsider the PR?
1. I looked up several open source projects
e.g:
[apisix](https://github.com/apache/apisix/blob/0670eff88fdadb4d4a1d306086993557f2e3e3bf/.github/workflows/build.yml#L5)
[skywalking](https://github.com/apache/skywalking/blob/e6265ba5be988c9b4c47252794a3684d544584d0/.github/workflows/ci-it.yaml#L21)
[kubesphere](https://github.com/kubesphere/kubesphere/blob/d814d5db7bde49b44b31ad8ddf14da5517bc0c78/.github/workflows/build.yml#L6)
they all run ci when push to master branch
1. the prs which does not have conflicts with the master branch, IMHO we did not need to do the rebase
but this is just my personal opinion, we can listen to others‘ suggestions. ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org