[jira] [Commented] (HBASE-13839) Fix AssgnmentManagerTmpl.jamon issues (coloring, content etc.)

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623193#comment-14623193 ] 

Hadoop QA commented on HBASE-13839:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12744860/hbase-13839-v1.patch
  against master branch at commit 5e708746b8d301c2fb22a85b8756129147012374.
  ATTACHMENT ID: 12744860

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1920 checkstyle errors (more than the master's current 1896 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/14749//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/14749//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/14749//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/14749//console

This message is automatically generated.

> Fix AssgnmentManagerTmpl.jamon issues (coloring, content etc.)
> --------------------------------------------------------------
>
>                 Key: HBASE-13839
>                 URL: https://issues.apache.org/jira/browse/HBASE-13839
>             Project: HBase
>          Issue Type: Bug
>          Components: master, UI
>    Affects Versions: 1.1.0
>            Reporter: Lars George
>            Assignee: Matt Warhaftig
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: hbase-13839-v1.patch
>
>
> The template for the RIT in the Master status page, AssignmentManagerTmpl.jamon) has a few issues:
> - The oldest RIT should not be _red_, looks like a failed entry
> The RIT entries should be for example yellow/amber when over the threshold time, and red if 2x the threshold - or red for the oldest once over the threshold.
> - Region count over RIT threshold should only be colored if > 0
> The summary line (first of two) should not be colored unless there is a value > 0 in it.
> - Color is overriden by table-stripped CSS style!
> The Bootstrap stylesheet cancels out the hardcoded coloring! The table-stripped resets the conditional coloring and should be fixed. Best is to use "alert-warning" etc. that come from the Bootstrap theme stylesheet. That should maybe already work in combination with the "table-stripped" from the same.
> - Should sort descending by time
> Currently the list of regions is sorted by encoded region name. Better is to have the table sorted by RIT time descending.
> We should also think about a pagination option for the currently hardcoded 100 entries max. Maybe a separate issue?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)