You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/09/12 05:49:05 UTC
[GitHub] [zookeeper] hanm commented on a change in pull request #1059:
[ZOOKEEPER-3512] Real time data consistency check during broadcast time
hanm commented on a change in pull request #1059: [ZOOKEEPER-3512] Real time data consistency check during broadcast time
URL: https://github.com/apache/zookeeper/pull/1059#discussion_r321833021
##########
File path: zookeeper-contrib/zookeeper-contrib-loggraph/src/main/java/org/apache/zookeeper/graph/TxnLogSource.java
##########
@@ -180,8 +180,10 @@ private LogEntry readNextEntry() {
throw new IOException("CRC doesn't match " + crcValue +
" vs " + crc.getValue());
}
- TxnHeader hdr = new TxnHeader();
- Record r = SerializeUtils.deserializeTxn(bytes, hdr);
+
+ TxnLogEntry logEntry = SerializeUtils.deserializeTxn(bytes);
Review comment:
nit: indentation here looks way off.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services